Skip to content

adding FromField and ToField instances for UTCTime#151

Open
mherzl wants to merge 1 commit into
haskell-hvr:masterfrom
mherzl:master
Open

adding FromField and ToField instances for UTCTime#151
mherzl wants to merge 1 commit into
haskell-hvr:masterfrom
mherzl:master

Conversation

@mherzl

@mherzl mherzl commented Aug 15, 2017

Copy link
Copy Markdown

Hi,

I appreciate your cassava repo.

Including these FromField and ToField instances for time's UTCTime would be useful to me.

Please feel free to let me know if I can be of help in getting this feature included.

Thank you!
Matthew

@ocramz

ocramz commented Feb 25, 2018

Copy link
Copy Markdown

@mherzl @hvr it seems like hvr/cassava is not in Travis anymore? I therefore can't see why this PR failed.

@hvr

hvr commented Feb 25, 2018

Copy link
Copy Markdown
Collaborator

@ocramz the logs for this PR moved to https://travis-ci.org/haskell-hvr/cassava/builds/264861856

However, I'm not convinced this PR to be non-controversial enough at this point. At the very least I'd expect a canonical ISO8601 based serialisation (including a timezone designation, like a trailing Z) that is able to round-trip UTCTime in a loss-less way and is able to deserialise time-zoned ISO8601 representations reasonably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants