H-5770: Add PlaybackContext for real-time simulation playback #8295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new PlaybackContext that handles viewing simulation frames at real-time speed based on dt, separate from the computation speed. - Create playback/context.ts with PlaybackContextValue type - Create playback/provider.tsx with requestAnimationFrame-based playback - Move currentViewedFrame from SimulationContext to PlaybackContext - Update all consumers to use PlaybackContext for frame viewing - SimulationContext now only handles computation/generation of frames - PlaybackContext advances frames at real-time speed (60Hz max) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
github-actions
bot
added
area/libs
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
the
area/infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Introduce a new PlaybackContext that handles viewing simulation frames at real-time speed based on
dt, separate from the computation speed. This allows the simulation to be computed as fast as possible while the visualization plays back at the correct real-time speed.🔗 Related links
🚫 Blocked by
Nothing
🔍 What does this change?
playback/context.tswithPlaybackContextValuetype defining playback state and actionsplayback/provider.tsxwithrequestAnimationFrame-based playback loopcurrentViewedFramefromSimulationContexttoPlaybackContextPlaybackContextfor frame viewingSimulationContextnow only handles computation/generation of framesPlaybackContextadvances frames at real-time speed (60Hz max) based ondtPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
None
🐾 Next steps
None
🛡 What tests cover this?
❓ How to test this?
yarn devdtrather than computation speed📹 Demo
N/A