Decouple delete permissions from resource paths - #95
Open
shwetamurali wants to merge 9 commits into
Open
Conversation
shwetamurali
marked this pull request as ready for review
July 29, 2026 19:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tfctlgates non-interactive DELETEs on a per-session permission keyed by resource class. Previously that class was inferred purely from the URL path, which broke for resources whose API path doesn't match their type name.For an explorer saved query, the delete path is
/organizations/{org}/explorer/views/{id}, so the class was inferred asviews. Granting--allow-delete=explorer-saved-queriesnever matched, and the delete was wrongly denied.Changes:
tfctl destroycommand for typed resource deletion declares its resource class directly from the registry without needing path inference.opts.ResourceTypefirst, falling back toClassFromPathonly for rawtfctl api -X DELETE.ClassFromPathhas explicit overrides for non-standard collection segments so raw API deletes authorize correctly too.New resources whose API collection segment differs from their type name must be added to
nonStandardPathClasses. Thedestroycommand needs no change since it usesResourceTypedirectly.Example Output
Authorized session (the case this PR fixes): grant is
explorer-saved-querieswhile the path is.../views/..., and it now matches:DELETE https://.../api/v2/organizations/my-org/explorer/views/sq-abcNo active session permission refuses in non-interactive mode:
PR Checklist
npx changie newor install changie to prepare a new changelog entry for the next set of release notes.--json— Force machine readable output to stdout. Does not apply to stderr.--markdown— Force markdown output to stdout. Does not apply to stderr.--dry-run— Don't make any actual writes or other mutations. Describe what would have changed to stderr.--quiet— Only render essential content.make gen/screenshotif the root command output changes.Autocompletefield to positional arguments and flags to assist shell autocomplete.PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.