Adding name option for output command.#256
Open
rambabuiitk wants to merge 3 commits intohashicorp:mainfrom
Open
Adding name option for output command.#256rambabuiitk wants to merge 3 commits intohashicorp:mainfrom
rambabuiitk wants to merge 3 commits intohashicorp:mainfrom
Conversation
Updated tests
Contributor
Author
|
@radeksimko As discuss separated the output option to this PR...Wondering if I could get a review for this |
radeksimko
requested changes
Dec 13, 2021
Member
radeksimko
left a comment
There was a problem hiding this comment.
Hi @rambabuiitk
This looks reasonable in principle, but unfortunately as you noticed the JSON output for output -json NAME differs significantly from output -json in that it doesn't contain any metadata about the type or sensitivity.
Therefore I'm afraid this is unsuitable for integration into the existing Output() interface.
The JSON output of terraform output -json is also now considered protected under Terraform v1 guarantees, so unlikely to change until at least v2.
Do you mind describing the use case which isn't served by the existing Output() / output -json and map key access?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated tests