[WIP] feat: add support for meta keys#323
Open
PrashantRaj18198 wants to merge 2 commits intohashicorp:mainfrom
Open
[WIP] feat: add support for meta keys#323PrashantRaj18198 wants to merge 2 commits intohashicorp:mainfrom
PrashantRaj18198 wants to merge 2 commits intohashicorp:mainfrom
Conversation
This commit adds support for leftMeta and rightMeta keys in boot commands, addressing the missing Meta key mappings in the VNC implementation. Changes: - Add leftmeta/rightmeta keysym mappings to VNC driver (0xFFE7/0xFFE8) - Add leftmeta/rightmeta mappings to USB driver (CodeLeftGUI/CodeRightGUI) - Update boot command parser grammar to recognize leftMeta/rightMeta - Regenerate boot_command.go from .pigeon grammar file - Update documentation to include Meta key usage Meta keys (0xFFE7/0xFFE8) are distinct from Super keys (0xFFEB/0xFFEC) according to the X11/VNC keysym standard (QEMU vnc_keysym.h). Users can now use <leftMetaOn>, <leftMetaOff>, <rightMetaOn>, and <rightMetaOff> in boot commands, similar to existing Alt key functionality. All existing tests pass successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add Meta key support to bootcommand VNC and USB drivers
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for meta keys which map to 'Option' keys on macs. We can use
<leftMetaOn/Off>and<rightMetaOn/Off>to signal the left and right Option key press.I haven't checked if the keypress maps to something in linux, let me know if this is required.
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
NA