mlock, password: add aix to unix build constraints - #190
Open
AdamTylerLynch wants to merge 1 commit into
Open
Conversation
GOOS=aix builds of both modules currently fail (undefined: lockMemory / undefined: read) because neither unix implementation file includes aix in its build constraint. The syscalls both files use are available on aix/ppc64 with the stock Go toolchain. Validated by the IBM Power integration team in AIX builds of the Vault CLI/Agent. Fixes hashicorp#189 Co-authored-by: Hari G Muralidharan <harimura@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
aixto the build constraints ofmlock/mlock_unix.goandpassword/password_unix.goso both modules compile forGOOS=aix GOARCH=ppc64.Fixes #189
Background
Both packages currently fail on AIX with
undefined: lockMemory/undefined: read— the platform falls through to no implementation. The syscalls used by the unix implementations are available on aix/ppc64 with the stock Go toolchain; no aix-specific code is needed, only the constraint.This patch has been validated by the IBM Power integration team, who have been carrying it as a fork patch for AIX builds of the Vault CLI/Agent (credited as commit co-author).
Testing
GOOS=aix GOARCH=ppc64 go build ./...in bothmlock/andpassword/— compilesgo build/go vet/go test— unchanged, greenmlock_unavail.gostill covers darwin/windows/etc.)