go: migrate from github.com/joyent/triton-go to github.com/TritonDataCenter/triton-go#326
Open
ryancragun wants to merge 1 commit intomasterfrom
Open
go: migrate from github.com/joyent/triton-go to github.com/TritonDataCenter/triton-go#326ryancragun wants to merge 1 commit intomasterfrom
ryancragun wants to merge 1 commit intomasterfrom
Conversation
…Center/triton-go While auditing the transitive dependencies for Vault I noticed that go-discover was still pulling in a very old version of the Triton library. I've updated it to track the still maintained version and deleted the unused vendor directory. As the gce module also declares go-discover a dep I also updated the psuedo version to a more modern version and tidied it based on these changes. NOTE: We probably ought to remove the vendor directories in the various providers as they predate Go Modules and are no longer needed. I've done that for triton but figured it was probably better to leave the others to different PRs. Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
force-pushed
the
ryan-update-triton
branch
from
7970d21 to
8f1fa33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While auditing the transitive dependencies for Vault I noticed that
go-discoverwas still pulling in a very old version of the Triton library. I've updated it to track the still maintained version and deleted the unusedvendordirectory.Note
We probably ought to remove the
vendordirectories in the various providers as they predate Go Modules and are no longer needed. I've done that for triton but figured it was probably better to leave the others to different PRs.PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.