build(deps): bump go version and x-repositories to latest#321
Open
dduzgun-security wants to merge 1 commit intomasterfrom
Open
build(deps): bump go version and x-repositories to latest#321dduzgun-security wants to merge 1 commit intomasterfrom
dduzgun-security wants to merge 1 commit intomasterfrom
Conversation
ssagarverma
reviewed
Apr 6, 2026
Collaborator
ssagarverma
left a comment
ssagarverma
left a comment
There was a problem hiding this comment.
@dduzgun-security Quick question: I understand bumping the Go version for the actual module(s), but I’m not clear on why we also need to update the go directive in nested vendored copies.
My assumption was that those vendored go.mod files are just snapshots of upstream dependencies and aren’t what governs the root build in module mode. Is there a specific reason for updating them too, such as re-vendoring, tooling, or a build issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.