aws: Use session.NewSession() instead of deprecated session.New() #206
Open
elprans wants to merge 3 commits intohashicorp:masterfrom
Open
aws: Use session.NewSession() instead of deprecated session.New() #206elprans wants to merge 3 commits intohashicorp:masterfrom
session.NewSession() instead of deprecated session.New() #206elprans wants to merge 3 commits intohashicorp:masterfrom
Conversation
|
|
elprans
changed the title
session.New() session.NewSession() instead of deprecated session.New()
elprans
force-pushed
the
master
branch
2 times, most recently
from
df6f402 to
d086882
Compare
The latter does not support environment variables properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session.New()has long been deprecated and does not allow for proper support of using environment variables for configuration. This precludes configuring the global behavior of AWS clients via environment, e.g. things likeAWS_USE_DUALSTACK_ENDPOINT.