Open
Conversation
|
|
ghost
suggested changes
Mar 7, 2025
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Thanks a lot for looking into this. Added some comments
| bytes.Contains(content, []byte("the opentofu authors")) || | ||
| bytes.Contains(content, []byte("hashicorp, inc.")) || | ||
| bytes.Contains(content, []byte("mozilla public")) || | ||
| bytes.Contains(content, []byte("spdx-license-identifier")) |
There was a problem hiding this comment.
Issue: Adding conditions in the above manner is not scalable
The current implementation is okay for small number of scenarios but adding more || conditions will make it unreadable. Also, the repo is currently consumed at a number of places and the above changes might not be required by everyone.
It will be great if you can come up with a solution where the different conditions can be supplied by the users as a config according to their use cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Updated the
hasLicensefunction to correctly detect old-style copyright headers that were previously missed.Changes Made:
"copyright (c)","hashicorp, inc.", and"the opentofu authors".🔗 External Links
👍 Definition of Done
🤔 Can be merged upon approval?
✅