ci: fix expression injection in embedded-asset-checker.yml - #23661
Open
XananasX7 wants to merge 1 commit into
Open
ci: fix expression injection in embedded-asset-checker.yml#23661XananasX7 wants to merge 1 commit into
XananasX7 wants to merge 1 commit into
Conversation
The dist-check step passed github.event.pull_request.base.ref
directly into a shell command:
git merge-base HEAD "origin/${{ github.event.pull_request.base.ref }}"
A pull request opened from a branch whose name contains shell
metacharacters (e.g. a semicolon or command substitution) would
cause arbitrary command execution in the runner.
Move the ref value into a BASE_REF env variable and reference it
as ${BASE_REF} in the shell script, which is the safe pattern
recommended by GitHub's security hardening guide and enforced by
tools such as zizmor and StepSecurity.
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
github-actions
Bot
added
type/ci
Author
|
I've signed the HashiCorp CLA at https://cla.hashicorp.com/hashicorp/consul using mehdiananas007@gmail.com. Should now be unblocked for review. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dist-check step in embedded-asset-checker.yml interpolates
github.event.pull_request.base.ref directly into a shell command:
git merge-base HEAD "origin/${{ github.event.pull_request.base.ref }}"
A pull request whose base branch name contains shell metacharacters
(semicolon, backtick, dollar sign followed by parenthesis, etc.)
would cause arbitrary command execution in the GitHub Actions runner.
The workflow is triggered by the pull_request event on the main and
release/* branches, so only trusted base branch names appear in
practice. However, defence-in-depth and tools such as zizmor and
StepSecurity flag all direct context interpolation regardless.
Fix: move github.event.pull_request.base.ref into a BASE_REF env:
variable and reference it as ${BASE_REF} in the shell step.
No behaviour change is intended.