[Plugins] Add LVTD Skills Plugin#217
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive catalog of reusable agent skills under plugins/LVTD-LLC/skills/ covering Django, Rust, SEO, and startup traction workflows, along with marketplace integration manifests and validation scripts. The review feedback correctly identifies two issues in the Rust SQLx persistence files: a logical error in sqlx-preflight.sh where a check should use && instead of || to ensure both the .sqlx directory and DATABASE_URL are present, and a compiler type mismatch in sqlx-patterns.md where a transaction must be explicitly dereferenced as &mut *tx when passed to helpers expecting &mut PgConnection.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| cargo fmt --all --check | ||
|
|
||
| if command -v sqlx >/dev/null 2>&1 && [ -d migrations ]; then | ||
| if [ -d .sqlx ] || [ -n "${DATABASE_URL:-}" ]; then |
There was a problem hiding this comment.
The cargo sqlx prepare --check command requires both the .sqlx directory to exist (to have metadata to check against) and a live database connection via DATABASE_URL (to verify the queries). Using a logical OR (||) here will cause the script to attempt running the check and fail if .sqlx exists but DATABASE_URL is not set, or vice versa. Changing this to a logical AND (&&) ensures the check only runs when both prerequisites are met.
| if [ -d .sqlx ] || [ -n "${DATABASE_URL:-}" ]; then | |
| if [ -d .sqlx ] && [ -n "${DATABASE_URL:-}" ]; then |
| Use transactions for workflows that update multiple rows or combine persistence | ||
| with idempotency state: | ||
|
|
||
| ```rust | ||
| let mut tx = pool.begin().await?; | ||
|
|
There was a problem hiding this comment.
In Rust with SQLx, Transaction implements DerefMut<Target = PgConnection>. When passing a transaction reference to helper functions that expect &mut PgConnection, you must explicitly dereference it using &mut *tx. Passing &mut tx directly will result in a compiler type mismatch error because &mut Transaction<'_, Postgres> does not automatically coerce to &mut PgConnection.
| Use transactions for workflows that update multiple rows or combine persistence | |
| with idempotency state: | |
| ```rust | |
| let mut tx = pool.begin().await?; | |
| let mut tx = pool.begin().await?; | |
| insert_issue(&mut *tx, issue).await?; | |
| mark_idempotency_key_used(&mut *tx, key).await?; | |
| tx.commit().await?; |
|
Thanks for the submission. Two things to fix before this can be merged:
The LVTD Skills plugin bundle itself looks good - once split into its own PR with the registry entries added, it should be ready to merge. |
2 participants
Summary
plugins/LVTD-LLC/skillswith manifest, icon assets, source skills, README, LICENSE, SECURITY.md, .codexignore, and package lockfile.plugins.jsonand.agents/plugins/marketplace.json.This is a clean replacement for #216, built from current
upstream/main.Contribution Guide Checklist
Source plugin repo: https://github.com/LVTD-LLC/skills
.github/workflows/hol-plugin-scanner.yml.codex-plugin/plugin.jsonSECURITY.mdLICENSEREADME.mdpackage-lock.jsonLocal scanner output from the source repo:
Validation
python3 scripts/check-alphabetical.py README.mdpython3 scripts/validate-plugin-pr.py --base-ref upstream/mainpython3 -m json.tool plugins.json >/dev/nullpython3 -m json.tool .agents/plugins/marketplace.json >/dev/nullpython3 -m json.tool plugins/LVTD-LLC/skills/.codex-plugin/plugin.json >/dev/nullgit diff --check --cached && git diff --checkI did not run
scripts/generate_plugins_json.py; the README entry, plugin bundle,plugins.json, and.agents/plugins/marketplace.jsonwere updated directly to avoid unrelated mirror changes.