Skip to content

Added Submissions page#66

Open
DestroyerAlpha wants to merge 7 commits into
developfrom
Submission
Open

Added Submissions page#66
DestroyerAlpha wants to merge 7 commits into
developfrom
Submission

Conversation

@DestroyerAlpha
Copy link
Copy Markdown
Collaborator

It is finally here! 🎆
Submissions page is here!
Please check and report any issues.
#44

@harshraj22
Copy link
Copy Markdown
Owner

I think display_question.php has button action set as submissions.html instead of submissions.php. Can you edit that as well ?

@DestroyerAlpha
Copy link
Copy Markdown
Collaborator Author

I think display_question.php has button action set as submissions.html instead of submissions.php. Can you edit that as well ?

fixed

@harshraj22
Copy link
Copy Markdown
Owner

Also, it seems ques_id is not being passed from display_question.php to submissions.php. Can you check ?

@DestroyerAlpha
Copy link
Copy Markdown
Collaborator Author

Also, it seems ques_id is not being passed from display_question.php to submissions.php. Can you check ?

Changed it to POST, now it works! 🤣

@JanhaviDadhania
Copy link
Copy Markdown
Collaborator

JanhaviDadhania commented Nov 14, 2019

Are you updating "practice questions info" table?
It contains all question Id , total no. of submissions for that question.

and
I think submission page is working even if we don't select any language.

and
It is working even if we directly try to access the page. In that case it won't have any ques_Id to insert into the table...
Screenshot from 2019-11-14 14-50-12

@DestroyerAlpha
Copy link
Copy Markdown
Collaborator Author

Is there a table per practice question or for all the practice questions?

@DestroyerAlpha
Copy link
Copy Markdown
Collaborator Author

Is there a table per practice question or for all the practice questions?

@JanhaviDadhania

@DestroyerAlpha
Copy link
Copy Markdown
Collaborator Author

DestroyerAlpha commented Nov 14, 2019

Fixed the bugs mentioned:

  • Added a query to update practice_questions_info

  • Added a query to add submission in question table

  • Added a check on submissions page for direct access!

Are you updating "practice questions info" table?
It contains all question Id , total no. of submissions for that question.

and
I think submission page is working even if we don't select any language.

and
It is working even if we directly try to access the page. In that case it won't have any ques_Id to insert into the table...
Screenshot from 2019-11-14 14-50-12

Copy link
Copy Markdown
Owner

@harshraj22 harshraj22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants