Repository navigation
fix(baseline): cap JSON baseline files before parsing - #35
Draft
harshitethic wants to merge 2 commits into
Draft
harshitethic wants to merge 2 commits into
harshitethic wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--baselineread the entire supplied file into memory without any bound, unlike scanner configuration reads. Accidentally passing an enormous file could consume excessive memory before reporting an error.Fix
Limit baseline input to 16 MiB at the binary-read boundary before UTF-8 decoding and JSON parsing. Ordinary baseline files remain compatible.
Tests
A normal JSON baseline is accepted and a sparse oversized file is rejected without parsing. CI pending.