Repository navigation
security(http): reject ambiguous duplicate Host headers - #41
Merged
harshitethic merged 2 commits intoOct 27, 2026
Merged
Conversation
harshitethic
marked this pull request as ready for review
October 27, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ApiAccessMiddlewarevalidatedheaders.get('host'), which can select one of multiple Host headers. Downstream proxy/server hops may select another, creating an inconsistent authority boundary for this powerful local code-editing API.Fix
Require exactly one Host header before origin and authentication checks in normal requests, independent of local/token mode. CORS preflight still cannot run handlers.
Tests
Real ASGI tests submit duplicate Host headers with and without a valid bearer token and assert rejection. Full CI pending.