Conversation
Owner
|
Thank you for identifying and fixing this issue. The distinction between advisory candidate ingestion and authoritative index validation is clear and well scoped. I also verified the change on Windows ARM64: the duplicate-candidate regression test passed, the full Core suite passed with 523 tests and no failures, and Thanks again for the thoughtful contribution! |
Owner
|
Your fix is now included in 1.0.9. Repeated paths from Spotlight no longer interrupt large-file scans or cause files and sizes to be counted twice. Thanks for the contribution and the regression test! I've also credited you in the release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
On macOS, a full-disk large-file scan can fail while consuming Spotlight results with:
Spotlight is an advisory candidate source and can repeat a path. A repeated, already-validated candidate should not abort the entire scan.
Safety
Live scope, protection policy, filesystem, link-type, and size validation still runs before insertion. Only the advisory candidate insertion is idempotent; the existing strict duplicate checks for authoritative traversal/index records remain unchanged.
Validation
pnpm checkcargo test --manifest-path src-tauri/Cargo.toml -p mangodisk-core(495 passed, 0 failed)