Handle stale snapshots by returning ErrSnapshotStale#5066
Draft
Frozen wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds additional stale state checks to the diff layer's account and storage retrieval methods, improving the robustness of snapshot state management. Now, before attempting to access account or storage data, the code verifies if the diff layer is stale and returns an appropriate error if so.
Improvements to snapshot diff layer safety:
Stale()in theAccountRLPmethod ofdiffLayerto prevent access and returnErrSnapshotStaleif the layer is stale.Stale()check in theStoragemethod ofdiffLayerto ensure safe handling of stale state.