Refactor configuration by removing Pangaea network references#5052
Open
Frozen wants to merge 3 commits into
Open
Refactor configuration by removing Pangaea network references#5052Frozen wants to merge 3 commits into
Frozen wants to merge 3 commits into
Conversation
Collaborator
Author
|
@copilot remove reference github.com/harmony-one/harmony/cmd/config [github.com/harmony-one/harmony/cmd/config.test]cmd/config/flags_test.go:413:58: undefined: nodeconfig.Pangaea` |
... Updated in commit |
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Resolved the merge conflicts by merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes all code, configuration, and references related to the "Pangaea" network from the codebase. This includes eliminating Pangaea from supported network types, bootnode and DNS configuration, sharding schedules, and genesis parameters. The changes help simplify the codebase by removing legacy support for a deprecated network.
The most important changes are:
Removal of Pangaea network support across the codebase:
internal/configs/sharding/pangaea.gofile, fully removing the Pangaea sharding schedule implementation.Pangaeanetwork type and all related logic from network type definitions, bootnode/DNS configuration, and chain config selection in files such asinternal/configs/node/config.go,internal/configs/node/network.go,internal/configs/bootnode/config.go, andinternal/configs/sharding/instance.go. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]cmd/config/flags.go,cmd/bootnode/main.go). [1] [2] [3]block/factory/factory.go,cmd/config/config.go,cmd/config/dumpdb.go,cmd/harmony/main.go,core/genesis.go). [1] [2] [3] [4] [5]Cleanup of legacy Pangaea-specific code:
core/blockchain_impl.go.These changes ensure that the codebase no longer contains any Pangaea-specific logic or configuration, reducing maintenance overhead and potential confusion.