Add shard state processing logic for non-epoch-ending blocks#5049
Open
Frozen wants to merge 1 commit into
Open
Add shard state processing logic for non-epoch-ending blocks#5049Frozen wants to merge 1 commit into
Frozen wants to merge 1 commit into
Conversation
…shard state in non-epoch-ending blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol and validation changes:
engineImpl.VerifyShardStateto reject non-epoch-ending blocks that carry shard state bytes, preventing the persistence of an empty next-epoch committee and potential consensus halt.Chain configuration updates:
ShardStateValidationEpochtoChainConfig, marking the epoch when the new shard state validation rule is enforced.ShardStateValidationEpochto the default, test, and test rules chain configuration parameter sets. [1] [2] [3]IsShardStateValidationhelper method for checking if the current epoch is past the activation epoch for shard state validation.