fix(py-dsl): satisfy ruff format + lint#45
Open
markovejnovic wants to merge 2 commits into
Open
Conversation
CI (hm run on Harmont cloud) flagged real failures in the harmont-py DSL: - ruff format: _bun.py and _toolchain.py had multi-line string concatenations that fit on one line; reformat them. - ruff check (E402): tests/test_bun.py imported pytest + harmont mid-file (after the first test batch). Hoist both to the module's import block. ruff format --check, ruff check, ty, and pytest (404 passed) all green.
examples/bun exists on disk but was missing from the example: matrix in examples.yml, so the validate-matrix guard failed. Add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the genuine
harmont-pyDSL lint/format failures surfaced when this repo's own CI pipeline ran end-to-end on the Harmont cloud (hm run):harmont/_bun.pyandharmont/_toolchain.pyhad multi-line string concatenations that fit on a single line; reformatted.tests/test_bun.pyimportedpytestandharmontmid-file (after the first batch of tests). Hoisted both into the module's import block.Verification (local, the exact CI commands)
cargo fmt --checkis also clean (unaffected — Python-only change).Context
No behavior change — formatting + import placement only. These were the only real (non-infra) failures in the cloud CI run; the rest of the chain (toolchain install, build, snapshot lineage) is now green on the Harmont side.