Repository navigation
Conversation
… #1734) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e21jov6Swn2Aj93SnF7
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e21jov6Swn2Aj93SnF7
… alone, update stale docs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e21jov6Swn2Aj93SnF7
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e21jov6Swn2Aj93SnF7
… signal, mark the second signal test partial Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e21jov6Swn2Aj93SnF7
…o signal can be registered Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e22ty6x1BTtW9RcfMkd
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1677
Ports upstream e2e-inc/e2e#1734
core/signals.tsandhandleSignals:LaunchOptions.HandleSignals(default true) closes the host on SIGINT, SIGTERM, and SIGHUP, says a failed close on stderr, and lets the signal end the program unless the program listens itself. Docs, skill reference, COMPATIBILITY.md and API reference updated.Upstream parity
Verdict: complete, with justified exceptions (follow-up #1704).
closeOnSignals(Core/Signals.cs),handleSignals->HandleSignals, stderr message, the threecore-signals.test.tsit(CoreSignals/CoreOnASignalTests.cs),core.mdx/reference/core.mdxcontent.Partial_ends_by_SIGHUP_...; the engine-listens half needsengineListeners, which .NET cannot do (no listing of registrations). Not ported:engineListeners, upstream's re-raise (the runtime's default action ends the process). Issue Core signals: mark engine-owned signal listeners (engineListeners, upstream core/signals.ts) #1704.Signalsis a .NET shape of the same file;CoreFakeEngine.OnDispose/OnEndAttemptstand for the fake engine'sonDispose/onEndAttempt; thecore-signalsmode inE2E.Tests.Appstands for the spawnedprogram.ts. The tests return early on Windows.Tests:
E2E.Core*60 passed, CoreSignals 3 passed (net10). Not run: RealModel tests (no agent change), net11 (not installed).Replaces #1694, which was closed unmerged; this is a fresh port from main.
Generated by Claude Code