Skip to content

Add WebFixtures (Browser, WebApp.BaseUrl) for IEngine<WebFixtures> on WebEngine - #1703

Merged
kblok merged 1 commit into
mainfrom
fix/1699-web-fixtures
Nov 16, 2026
Merged

kblok merged 1 commit into
mainfrom
fix/1699-web-fixtures

Conversation

@kblok

@kblok kblok commented Nov 16, 2026

Copy link
Copy Markdown
Member

Closes #1699

WebEngine now implements IEngine<WebFixtures>. Launch.LaunchAsync(new WebEngine(), ...) returns a Host<WebFixtures>. Its sessions expose Fixtures.Browser and Fixtures.App, a WebApp whose BaseUrl is never null.

Changes

  • New WebFixtures and WebApp in src/E2E/Engine/WebFixtures.cs. Upstream: packages/web/src/fixtures.ts.
  • App is no longer sealed and gains a private-protected copy constructor, so WebApp can extend it as upstream's WebApp extends App does.
  • IEngine<TFixtures>.CreateFixtures now also takes the Session the harness built, because Browser and App live there and not on the engine session.
  • MobileEngine and the test fake follow the new signature.
  • skills/e2e-dotnet/references/host.md, core.mdx and the generated API reference are updated.

Upstream parity

Upstream: tester-army/e2e #1734, packages/web/src/fixtures.ts and engine.ts (defineEngine<WebFixtures>).

  • ported: WebApp, WebFixtures (Browser, App).
  • port-only: CreateFixtures(IEngineSession, Session) takes the session as well. C# has no fixture intersection types and Browser and App are built by the harness. App's copy constructor exists so WebApp can extend App.
  • Tests: upstream has no it covering web fixtures. I added none. Upstream's engine.test.ts "refuses a fixture named like a method of an @e2e-dev/core session" is not ported, because C# fixtures are one Fixtures member, so no collision is possible. That reason is already given in Core: WebFixtures (browser, WebApp.BaseUrl) for IEngine<TFixtures> on WebEngine (upstream #1734) #1699.
  • Not verified here: no real-model test or browser run covers WebFixtures. The existing Core tests (59) pass on net10.0.
  • Verdict: complete.

Generated by Claude Code

… WebEngine (upstream #1734)

Closes #1699

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1zrGq2gUwMKsCiCozN
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 275ec02 and afa29e1.

Files selected for processing: 17

  • docs-site/public/api/E2E.Engine.WebApp.html
  • docs-site/public/api/E2E.Engine.WebFixtures.html
  • docs-site/src/content/docs/api/E2E.Engine/IEngine-1.md
  • docs-site/src/content/docs/api/E2E.Engine/WebApp.md
  • docs-site/src/content/docs/api/E2E.Engine/WebEngine.md
  • docs-site/src/content/docs/api/E2E.Engine/WebFixtures.md
  • docs-site/src/content/docs/api/E2E.Engine/index.md
  • docs-site/src/content/docs/api/E2E/App.md
  • docs-site/src/content/docs/docs/core.mdx
  • skills/e2e-dotnet/references/host.md
  • src/E2E.Mobile/MobileEngine.cs
  • src/E2E/Core/Launch.cs
  • src/E2E/Engine/IEngine.cs
  • src/E2E/Engine/WebEngine.cs
  • src/E2E/Engine/WebFixtures.cs
  • src/E2E/Run/Fixtures.cs
  • tests/E2E.Tests/Core/CoreFakeEngine.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok
kblok merged commit 45880d4 into main Nov 16, 2026
4 checks passed
@kblok
kblok deleted the fix/1699-web-fixtures branch November 16, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Core: WebFixtures (browser, WebApp.BaseUrl) for IEngine<TFixtures> on WebEngine (upstream #1734)

2 participants