Repository navigation
Add WebFixtures (Browser, WebApp.BaseUrl) for IEngine<WebFixtures> on WebEngine - #1703
Merged
Merged
Conversation
… WebEngine (upstream #1734) Closes #1699 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1zrGq2gUwMKsCiCozN
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1699
WebEnginenow implementsIEngine<WebFixtures>.Launch.LaunchAsync(new WebEngine(), ...)returns aHost<WebFixtures>. Its sessions exposeFixtures.BrowserandFixtures.App, aWebAppwhoseBaseUrlis never null.Changes
WebFixturesandWebAppinsrc/E2E/Engine/WebFixtures.cs. Upstream:packages/web/src/fixtures.ts.Appis no longer sealed and gains a private-protected copy constructor, soWebAppcan extend it as upstream'sWebApp extends Appdoes.IEngine<TFixtures>.CreateFixturesnow also takes theSessionthe harness built, becauseBrowserandApplive there and not on the engine session.MobileEngineand the test fake follow the new signature.skills/e2e-dotnet/references/host.md,core.mdxand the generated API reference are updated.Upstream parity
Upstream: tester-army/e2e #1734,
packages/web/src/fixtures.tsandengine.ts(defineEngine<WebFixtures>).WebApp,WebFixtures(Browser,App).CreateFixtures(IEngineSession, Session)takes the session as well. C# has no fixture intersection types andBrowserandAppare built by the harness.App's copy constructor exists soWebAppcan extendApp.itcovering web fixtures. I added none. Upstream'sengine.test.ts"refuses a fixture named like a method of an @e2e-dev/core session" is not ported, because C# fixtures are oneFixturesmember, so no collision is possible. That reason is already given in Core: WebFixtures (browser, WebApp.BaseUrl) for IEngine<TFixtures> on WebEngine (upstream #1734) #1699.WebFixtures. The existing Core tests (59) pass on net10.0.Generated by Claude Code