Skip to content

Type a host and a session by their engine's fixtures (upstream #1734) - #1700

Merged
kblok merged 1 commit into
mainfrom
fix/1696-engine-typed-fixtures
Nov 16, 2026
Merged

kblok merged 1 commit into
mainfrom
fix/1696-engine-typed-fixtures

Conversation

@kblok

@kblok kblok commented Nov 16, 2026

Copy link
Copy Markdown
Member

Closes #1696

Ports upstream e2e-inc/e2e#1734 (dbe3dc5) engine-typed fixtures: IEngine<TFixtures> (upstream EngineHandle<Fixtures>), Launch.LaunchAsync<TFixtures>, Host<TFixtures>, Session<TFixtures> with Fixtures, and MobileFixtures (Device) on MobileEngine. Docs, skill and API reference updated. The 'opens sessions one at a time...' it is now fully ported (no longer partial), with a gadget fixture on the fake engine.

Upstream parity

  • Ported: IEngine, LaunchAsync, Host, Session, MobileFixtures, the core it.
  • Port-only (.NET): Session<TFixtures>.Fixtures member, because C# has no intersection types (upstream CoreFixtures & Fixtures & SessionControls); Browser stays in the expected member list of the test for the same reason it is on every port session.
  • Not ported, tracked in Core: WebFixtures (browser, WebApp.BaseUrl) for IEngine<TFixtures> on WebEngine (upstream #1734) #1699: WebFixtures (web engine), and engine.test.ts 'refuses a fixture named like a method of an @e2e-dev/core session' (no collision possible with one Fixtures member).
  • Verdict: complete, with the exceptions above.

Generated by Claude Code

…1734)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e22Vkrdd6oNeFajzj4G
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 6f52e30 and 97c9750.

Files selected for processing: 23

  • docs-site/public/api/E2E.Engine.IEngine-1.html
  • docs-site/public/api/E2E.Host-1.html
  • docs-site/public/api/E2E.Session-1.html
  • docs-site/src/content/docs/api/E2E.Engine/EngineStartOptions.md
  • docs-site/src/content/docs/api/E2E.Engine/IBrowserProvider.md
  • docs-site/src/content/docs/api/E2E.Engine/IEngine-1.md
  • docs-site/src/content/docs/api/E2E.Engine/index.md
  • docs-site/src/content/docs/api/E2E/E2ESessionOptions.md
  • docs-site/src/content/docs/api/E2E/Host-1.md
  • docs-site/src/content/docs/api/E2E/Launch.md
  • docs-site/src/content/docs/api/E2E/LaunchOptions.md
  • docs-site/src/content/docs/api/E2E/ScriptedModel.md
  • docs-site/src/content/docs/api/E2E/Session-1.md
  • docs-site/src/content/docs/api/E2E/Session.md
  • docs-site/src/content/docs/api/E2E/index.md
  • docs-site/src/content/docs/docs/core.mdx
  • skills/e2e-dotnet/references/host.md
  • src/E2E.Mobile/MobileEngine.cs
  • src/E2E.Mobile/MobileFixtures.cs
  • src/E2E/Core/Launch.cs
  • src/E2E/Engine/IEngine.cs
  • tests/E2E.Tests/Core/CoreFakeEngine.cs
  • tests/E2E.Tests/Core/CoreTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok
kblok merged commit 275ec02 into main Nov 16, 2026
4 checks passed
@kblok
kblok deleted the fix/1696-engine-typed-fixtures branch November 16, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Core: engine-typed fixtures (Host<Fixtures>, Session<Fixtures>) and a Device member on Session (upstream #1734)

2 participants