Repository navigation
Fix flaky action-budget re-read test - #1663
Merged
Merged
Conversation
The test's fake clock used real timers, so a slow runner cut a read short with observe timed out. Use manual timers so the budget ends only when the test spends time. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e22fmrR6NnRk8W7bgDu
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1662
The test's
FakeClockused real timers unlessManualTimersis set. With 150 ms of budget and a 10 ms step, the last read's real 10 ms timer could fire before the fake device answered on a slow runner, givingobserve timed out before the device answered. The test now setsManualTimers = true, as the other fake-clock budget tests do, so the budget ends only when the test spends time.Upstream parity
Not applicable. The change is a .NET-only test-harness fix; the test keeps its upstream name, steps and assertions.
Verification: the test passes 3/3 on net10.0; the full
E2E.Mobile.Testsrun has 585 passing. The twoLeaseDaemonfailures neednpxand the network, which this sandbox lacks, and my change doesn't touch them.Generated by Claude Code