Skip to content

Fix flaky action-budget re-read test - #1663

Merged
kblok merged 1 commit into
mainfrom
fix/1662-flaky-action-budget-test
Nov 15, 2026
Merged

kblok merged 1 commit into
mainfrom
fix/1662-flaky-action-budget-test

Conversation

@kblok

@kblok kblok commented Nov 15, 2026

Copy link
Copy Markdown
Member

Closes #1662

The test's FakeClock used real timers unless ManualTimers is set. With 150 ms of budget and a 10 ms step, the last read's real 10 ms timer could fire before the fake device answered on a slow runner, giving observe timed out before the device answered. The test now sets ManualTimers = true, as the other fake-clock budget tests do, so the budget ends only when the test spends time.

Upstream parity

Not applicable. The change is a .NET-only test-harness fix; the test keeps its upstream name, steps and assertions.

Verification: the test passes 3/3 on net10.0; the full E2E.Mobile.Tests run has 585 passing. The two LeaseDaemon failures need npx and the network, which this sandbox lacks, and my change doesn't touch them.


Generated by Claude Code

The test's fake clock used real timers, so a slow runner cut a read short with
observe timed out. Use manual timers so the budget ends only when the test spends time.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e22fmrR6NnRk8W7bgDu
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 72208da and 5122bf8.

Files selected for processing: 1

  • tests/E2E.Mobile.Tests/Engine/DeterministicActionsTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok
kblok merged commit cf22005 into main Nov 15, 2026
4 checks passed
@kblok
kblok deleted the fix/1662-flaky-action-budget-test branch November 15, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky: DeterministicActionsTests.Stops_re_reading_a_moving_control_once_the_action_budget_cannot_fit_another_poll_and_sends_nothing

2 participants