Skip to content

ExploreState bounds test: pin expected, actual and path caps (upstream #1792) - #1661

Merged
kblok merged 1 commit into
mainfrom
fix/1653-explore-caps
Nov 15, 2026
Merged

kblok merged 1 commit into
mainfrom
fix/1653-explore-caps

Conversation

@kblok

@kblok kblok commented Nov 15, 2026

Copy link
Copy Markdown
Member

Closes #1653

Test-only change: the bounds test in ExploreStateTests now feeds 2,500-character expected, actual and path and asserts the 2,000 / 2,000 / 2,048 caps, as upstream's it does. ExploreState already had these caps (MaxDetailChars, MaxPathChars), so no src/ change.

Upstream parity

Verdict: matches e2e-inc/e2e#1792 (020c57d) for the explore-state test. Not ported: upstream's assertValidExplore JSON-schema validation, which the port has no schema for (already noted in a comment on the test). No public API or docs change, so no docs update. No real-model tests needed (test-only).

Tests: ExploreStateTests 10/10 pass on net10.0. /code-review: test-only diff, no findings.


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between cc701be and b4a144a.

Files selected for processing: 1

  • tests/E2E.Tests/ExploreState/ExploreStateTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok
kblok merged commit 905d8ac into main Nov 15, 2026
4 checks passed
@kblok
kblok deleted the fix/1653-explore-caps branch November 15, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream: pin explore finding expected, actual and path caps in the ExploreState bounds test (tester-army/e2e#1792)

2 participants