Repository navigation
Persist the --debug executor transcript as a log artifact - #1660
Merged
Merged
Conversation
…pstream loop guards and transcripts test) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1z2aRNMPxSDhMu96at
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1657
What changed
--- turn N ---,tool call:lines, results,[loop]notes, preamble notes) and attaches it withAttachTranscript, capped at 262,144 chars.ActContext.WriteTranscriptwritestranscript-<step id>.txtinto the attempt's artifact directory and registers it as a step-attributedlogartifact (upstream'swriteTranscript). The oldScreenshotContext.KeepTranscriptis removed.LoopGuardsAndTranscriptsTestsnow ports the whole upstreamit(name, debug on, log artifact kind and producer,tool call: tap,--- turn 1 ---); thePartial_prefix and comment are gone.debugging.md,COMPATIBILITY.md, XML doc and API page ofAttachTranscript.Upstream parity
Ported from tester-army/e2e
agent/tool-loop.ts(attachTranscript,MAX_TRANSCRIPT_CHARS, preamble) andagent/act.ts(writeTranscript), and theloop guards and transcriptsitinagent-act.test.ts. Verdict: complete.CoreTests.RunAsyncgained adebugflag andAttemptfields to read the artifact (test plumbing). Redact-before-clip in the loop is the existing deliberate difference.Checks
Targeted tests pass (18 transcript/debug/loop-guard tests). The full suite and real-model tests were not run: no Playwright browser and no Copilot login in this environment.
Generated by Claude Code