Skip to content

ExploreState test: pin finding expected, actual and path caps - #1659

Merged
kblok merged 1 commit into
mainfrom
fix/1653-explore-state-caps
Nov 15, 2026
Merged

kblok merged 1 commit into
mainfrom
fix/1653-explore-state-caps

Conversation

@kblok

@kblok kblok commented Nov 15, 2026

Copy link
Copy Markdown
Member

Closes #1653

Ports the test change from e2e-inc/e2e#1792 (commit 020c57d, explore-state.test.ts). The bounds test now feeds 2,500-character expected, actual and path and asserts caps of 2,000, 2,000 and 2,048. The 500-character reproduction cap was already asserted. The ExploreState caps already matched upstream, so no src/ change.

Upstream parity

  • Upstream change: e2e-inc/e2e@020c57d. It touches one file, one test.
  • Ported: all 4 added or changed assertions and the 3 new inputs. Renamed, partial, missing and port-only: none.
  • Existing note kept: upstream also validates the snapshot against the report JSON schema, which the port lacks. The test name omits "schema-valid" for that reason.
  • Repo rules: test layout is unchanged (ExploreState/ExploreStateTests.cs). No public API change, so no docs update. No real-model test is needed for a unit-test-only change.
  • Verdict: complete.

Tests: ExploreStateTests 10/10 pass on net10.0.


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between cc701be and 0deb339.

Files selected for processing: 1

  • tests/E2E.Tests/ExploreState/ExploreStateTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok
kblok merged commit fe1cd74 into main Nov 15, 2026
5 of 6 checks passed
@kblok
kblok deleted the fix/1653-explore-state-caps branch November 15, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream: pin explore finding expected, actual and path caps in the ExploreState bounds test (tester-army/e2e#1792)

2 participants