Repository navigation
fix(mobile): keep userinfo out of openLink and openApp step labels - #1656
Merged
Merged
Conversation
Port of e2e-inc/e2e#1787. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e21C6wPWNN1XFLchD41
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1652
Ports e2e-inc/e2e#1787 (74435e2).
Changes
DeviceLinks.LinkLabelreads the link as a URL parser does (tabs and line breaks dropped, backslashes, slashless web links) and drops userinfo, query and fragment. A string that does not parse shows as<link>.DeviceLinks.AppLabel(upstreamappLabel): the app id as it is,<link>when it is shaped like a link.Device.OpenAppAsyncuses it.itoflinks.test.ts(4) added toLinks/LinksTests.cs; the changedengine.test.tsitupdated inEngine/DeviceFixtureTests.cs.skills/e2e-dotnet/references/debugging.mdand theOpenLinkAsyncXML doc mirror upstream'sdocs/reference/mobile.mdxchange.Upstream parity
Complete for the commit's source, tests and docs. .NET has no WHATWG URL parser, so
LinkLabelis a hand-written reader of the same rules (a .NET-only concern; the private helpersNonSpecialLabel,Authority,PathLabelexist for that). Not covered: dot-segment and percent-encoding normalisation, which no upstream test checks.Verification
The sandbox has no .NET 11 SDK, so the test project could not be built here. I ran the label cases of all four upstream tests against a copy of
DeviceLinks.csin a net10 console project: all passed. CI builds and runs the real tests./code-reviewand the real-model tests were not run (no login in this environment).Generated by Claude Code