Skip to content

fix(mobile): keep userinfo out of openLink and openApp step labels - #1656

Merged
kblok merged 1 commit into
mainfrom
fix/1652-link-label-userinfo
Nov 15, 2026
Merged

kblok merged 1 commit into
mainfrom
fix/1652-link-label-userinfo

Conversation

@kblok

@kblok kblok commented Nov 15, 2026

Copy link
Copy Markdown
Member

Closes #1652

Ports e2e-inc/e2e#1787 (74435e2).

Changes

  • DeviceLinks.LinkLabel reads the link as a URL parser does (tabs and line breaks dropped, backslashes, slashless web links) and drops userinfo, query and fragment. A string that does not parse shows as <link>.
  • New DeviceLinks.AppLabel (upstream appLabel): the app id as it is, <link> when it is shaped like a link. Device.OpenAppAsync uses it.
  • Tests: every new it of links.test.ts (4) added to Links/LinksTests.cs; the changed engine.test.ts it updated in Engine/DeviceFixtureTests.cs.
  • skills/e2e-dotnet/references/debugging.md and the OpenLinkAsync XML doc mirror upstream's docs/reference/mobile.mdx change.

Upstream parity

Complete for the commit's source, tests and docs. .NET has no WHATWG URL parser, so LinkLabel is a hand-written reader of the same rules (a .NET-only concern; the private helpers NonSpecialLabel, Authority, PathLabel exist for that). Not covered: dot-segment and percent-encoding normalisation, which no upstream test checks.

Verification

The sandbox has no .NET 11 SDK, so the test project could not be built here. I ran the label cases of all four upstream tests against a copy of DeviceLinks.cs in a net10 console project: all passed. CI builds and runs the real tests. /code-review and the real-model tests were not run (no login in this environment).


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between afe0d60 and 697e552.

Files selected for processing: 5

  • skills/e2e-dotnet/references/debugging.md
  • src/E2E.Mobile/Device.cs
  • src/E2E.Mobile/DeviceLinks.cs
  • tests/E2E.Mobile.Tests/Engine/DeviceFixtureTests.cs
  • tests/E2E.Mobile.Tests/Links/LinksTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok
kblok merged commit 3a135af into main Nov 15, 2026
4 checks passed
@kblok
kblok deleted the fix/1652-link-label-userinfo branch November 15, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream: keep userinfo out of openLink and openApp step labels (tester-army/e2e#1787)

2 participants