Repository navigation
ACP test: check a screenshot reaches the agent as an MCP image - #1655
Merged
Merged
Conversation
…eam executor.test.ts) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yksMmpn1uTVKXKPpL
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kblok
pushed a commit
that referenced
this pull request
Nov 15, 2026
Takes main's type_secret name argument (#1650) and the ACP screenshot check (#1655) with the upstream tool names, and lists type_secret for every ACP step. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1xnBhxbpAgMwCuPBUA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1651
Ports the screenshot check of upstream's
lists the tools once and tells the agent which ones a step does not offer(packages/acp/tests/executor.test.ts). The test now runs over the web engine against a local page and checks thatscreenshotreaches the agent as an MCPimage/pngresult. It drops thePartial_prefix.Local run:
E2E.Acp.Tests38 passed (net10.0).Upstream parity
Verdict: the screenshot assertion is ported. One part is not: upstream's step offers a
type_secretverb with no declared secrets, and expects the tool listed and refused at call time. The port listsfill_secretonly for declared secrets (#1647, matching upstream's later tool listing), so the test asserts it is not listed. This was already so before this PR..NET-only code:
PixelSiteinAcpHarness.cs(a local HTTP page for the web engine; upstream's step context mocks the observation instead) and abaseUrlparameter onStartAsync.No
src/change, no docs change (test-only). Real-model tests skipped: no agent change.Generated by Claude Code