Repository navigation
Agent tools: fill_secret takes name, as upstream's type_secret (#1646) - #1650
Merged
Merged
Conversation
The node target is now one id (#1649), so the secret's name no longer collides with a target field. The MCP type_secret description lists the configured secrets. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e21pM1pH12yG3orQ5KF
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e21pM1pH12yG3orQ5KF
…l reads name as the node Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e21pM1pH12yG3orQ5KF
kblok
pushed a commit
that referenced
this pull request
Nov 15, 2026
Takes main's type_secret name argument (#1650) and the ACP screenshot check (#1655) with the upstream tool names, and lists type_secret for every ACP step. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1xnBhxbpAgMwCuPBUA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1646
What changed
fill_secrettakestargetandname(the secret's name), as upstream'stype_secret. The oldsecretfield is gone; it only existed because the node target had its ownname(fixed by Agent tools: address nodes by a single target id, as upstream #1649).type_secrettool takesnametoo, and its description lists the configured secrets as"name" (purpose), like upstream's grammar tool.TestLinesreadsname.role/namenow use atargetid (GesturesSession.RefFor(request, line)).skills/e2e-dotnet/references/mcp.md,references/agent.md,docs-sitecoding-agents.mdx.Upstream parity
Upstream:
tester-army/e2epackages/e2e/src/agent/primitives.ts(type_secret:{ target, name }) andpackages/e2e/src/mcp/session.ts.namefield, MCP description listing secrets.fill/fill_secretvstype/type_secret. PR Name the agent tools as upstream and port the default toolset test on the web engine (#1630) #1645 renames them and is open; this PR is written against main's names and will need a trivial conflict resolution on the merge order.secretHandlesoptional parameter ofSessionCatalog.Create(a .NET-only plumbing of the secrets' purposes; upstream passes the config's secrets to the grammar).GesturesSession.RefFor(ModelRequest, string)is a test helper.namefield; the tool rename is tracked by Name the agent tools as upstream and port the default toolset test on the web engine (#1630) #1645.Checks
E2E.TestsAgentActVerdictMapping, AnInconclusiveJudgmentAfterASecretFill, GrammarToolsHaveClosedSchemas, E2eExplore: 51 passed.E2E.Cli.Tests: 524 passed, 9 failed. The failures launch a browser or a child server and this sandbox has no Chromium; not rerun on a machine with one.E2E.Tests(SecretFillPolicyUnderAHostileModel,SecretsCutShortByObservationLimits) for the same reason, and the real-model tests (no Copilot login here). CI should cover the former.Generated by Claude Code