Skip to content

Agent tools: fill_secret takes name, as upstream's type_secret (#1646) - #1650

Merged
kblok merged 3 commits into
mainfrom
fix/1646-type-secret-name
Nov 15, 2026
Merged

kblok merged 3 commits into
mainfrom
fix/1646-type-secret-name

Conversation

@kblok

@kblok kblok commented Nov 15, 2026

Copy link
Copy Markdown
Member

Closes #1646

What changed

  • fill_secret takes target and name (the secret's name), as upstream's type_secret. The old secret field is gone; it only existed because the node target had its own name (fixed by Agent tools: address nodes by a single target id, as upstream #1649).
  • The MCP type_secret tool takes name too, and its description lists the configured secrets as "name" (purpose), like upstream's grammar tool. TestLines reads name.
  • Scripted tests that still addressed the node by role/name now use a target id (GesturesSession.RefFor(request, line)).
  • Docs: skills/e2e-dotnet/references/mcp.md, references/agent.md, docs-site coding-agents.mdx.

Upstream parity

Upstream: tester-army/e2e packages/e2e/src/agent/primitives.ts (type_secret: { target, name }) and packages/e2e/src/mcp/session.ts.

Checks

  • E2E.Tests AgentActVerdictMapping, AnInconclusiveJudgmentAfterASecretFill, GrammarToolsHaveClosedSchemas, E2eExplore: 51 passed.
  • E2E.Cli.Tests: 524 passed, 9 failed. The failures launch a browser or a child server and this sandbox has no Chromium; not rerun on a machine with one.
  • Not run: the browser-backed E2E.Tests (SecretFillPolicyUnderAHostileModel, SecretsCutShortByObservationLimits) for the same reason, and the real-model tests (no Copilot login here). CI should cover the former.

Generated by Claude Code

The node target is now one id (#1649), so the secret's name no longer
collides with a target field. The MCP type_secret description lists the
configured secrets.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e21pM1pH12yG3orQ5KF
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between afe0d60 and 03492b2.

Files selected for processing: 19

  • docs-site/src/content/docs/coding-agents.mdx
  • skills/e2e-dotnet/references/agent.md
  • skills/e2e-dotnet/references/mcp.md
  • src/E2E.Cli/Mcp/Session.cs
  • src/E2E.Cli/Mcp/SessionCatalog.cs
  • src/E2E.Cli/Mcp/TestLines.cs
  • src/E2E/Agent/ActTools.cs
  • src/E2E/Agent/AgentTools.cs
  • tests/E2E.Cli.Tests/McpServer/E2EMcpTests.cs
  • tests/E2E.Cli.Tests/McpTestLines/E2EMcpTestLinesTests.cs
  • tests/E2E.Cli.Tests/McpTestLines/SessionTestLinesTests.cs
  • tests/E2E.Tests/Agent/AnInconclusiveJudgmentAfterASecretFillTests.cs
  • tests/E2E.Tests/AgentAct/AgentActVerdictMappingTests.cs
  • tests/E2E.Tests/AgentActStress/SecretFillPolicyUnderAHostileModelTests.cs
  • tests/E2E.Tests/AgentActVerbs/GesturesSession.cs
  • tests/E2E.Tests/AgentGrammarTools/TheGrammarToolsHaveClosedSchemasTests.cs
  • tests/E2E.Tests/Explore/E2eExploreTests.cs
  • tests/E2E.Tests/TraceReplay/ReplayThroughTheActTests.cs
  • tests/E2E.Tests/TruncatedSecrets/SecretsCutShortByObservationLimitsTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e21pM1pH12yG3orQ5KF
…l reads name as the node

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e21pM1pH12yG3orQ5KF
@kblok
kblok merged commit cc701be into main Nov 15, 2026
4 checks passed
@kblok
kblok deleted the fix/1646-type-secret-name branch November 15, 2026 13:23
kblok pushed a commit that referenced this pull request Nov 15, 2026
Takes main's type_secret name argument (#1650) and the ACP screenshot check (#1655)
with the upstream tool names, and lists type_secret for every ACP step.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1xnBhxbpAgMwCuPBUA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent tools: fill_secret takes secret, upstream type_secret takes name

2 participants