Skip to content

Clarify hosted-device requirements in the BrowserStack guide - #1564

Merged
kblok merged 1 commit into
mainfrom
docs/1563-hosted-device-requirements
Nov 11, 2026
Merged

kblok merged 1 commit into
mainfrom
docs/1563-hosted-device-requirements

Conversation

@kblok

@kblok kblok commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Closes #1563

Ports the BrowserStack part of e2e-inc/e2e#1671 (220f22c): the requirements line now reads "No Mac, Xcode, or Android SDK is required to run e2e with hosted devices."

Upstream parity

  • Upstream change: e2e-inc/e2e@220f22c (public repo). Its diff for docs/integrations/browserstack.mdx, the only page the port has:
 <Tip>
-No Mac, Xcode, or Android SDK on the machine that runs e2e.
+No Mac, Xcode, or Android SDK is required to run e2e with hosted devices.
 </Tip>
  • Ported: 1 (integrations/browserstack.mdx, same sentence). Renamed/partial/missing/port-only: 0.
  • Not applicable: e2b.mdx, eas.mdx, testmu.mdx do not exist in the port; the provider gap issues track them. The upstream commit adds or changes no tests.
  • No code, tests, or public API changed, so SKILL.md and the API reference are unaffected.
  • Repo rules checked (CLAUDE.md): docs-only, no src/ symbols, no tests.
  • Verdict: complete.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e3b6356 and 07190fc.

Files selected for processing: 1

  • docs-site/src/content/docs/integrations/browserstack.mdx

No actionable comments were generated in the recent review.

Walkthrough

The BrowserStack guide now states that running e2e tests with hosted devices does not require a Mac, Xcode, or Android SDK on the runner.

Changes: BrowserStack guide

Layer / File(s) Summary
Hosted-device requirements
docs-site/src/content/docs/integrations/browserstack.mdx
The guide changes its requirements statement to clarify that these tools are not needed to run e2e tests with hosted devices.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related PRs

  • hardkoded/e2e-dotnet#1397: Documents BrowserStack real-device support in release notes and links to the BrowserStack guide.
Merge Risk: Minimal · up to 07190

This is a documentation-only wording change clarifying that hosted-device e2e runs do not need a Mac, Xcode, or Android SDK. It poses no runtime risk and is safe to merge.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Upstream Parity Inconclusive The PR changes only the BrowserStack guide. Its sentence matches the upstream text quoted in the PR. The PR reports that the upstream commit changed no tests, but linked-repository inspection is unava… Provide the upstream commit diff to verify whether it added or changed any it tests.
Passed Passed checks: 4 passed

Check name Status Explanation
Title check Passed The title clearly and concisely describes the documentation change to BrowserStack hosted-device requirements.
Linked Issues check Passed Issue #1563 requires the BrowserStack guide to use the updated hosted-device requirements wording. The PR changes docs-site/src/content/docs/integrations/browserstack.mdx from one line to the wordin…
Out of Scope Changes check Passed The PR changes only the BrowserStack documentation line required by issue #1563. The summary reports no code, test, or public API changes. No unrelated change is demonstrated.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Linked Issues check

Explanation

Issue #1563 requires the BrowserStack guide to use the updated hosted-device requirements wording. The PR changes docs-site/src/content/docs/integrations/browserstack.mdx from one line to the wording: “No Mac, Xcode, or Android SDK is required to run e2e with hosted devices.”

Full details: Upstream Parity

Explanation

The PR changes only the BrowserStack guide. Its sentence matches the upstream text quoted in the PR. The PR reports that the upstream commit changed no tests, but linked-repository inspection is unavailable. COMPATIBILITY.md does not establish the test changes in commit 220f22c.

Resolution

Provide the upstream commit diff to verify whether it added or changed any it tests.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped tester-army/e2e.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e3b6356 and 07190fc.

Files selected for processing: 1

  • docs-site/src/content/docs/integrations/browserstack.mdx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@kblok

kblok commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai Upstream diff for tester-army/e2e commit 220f22c (public repo), docs/integrations/browserstack.mdx, the only page the port has:

 <Tip>
-No Mac, Xcode, or Android SDK on the machine that runs e2e.
+No Mac, Xcode, or Android SDK is required to run e2e with hosted devices.
 </Tip>

This PR sets the port's line to the same sentence. The commit's other files (e2b.mdx, eas.mdx, testmu.mdx) have no page in the port, and it adds or changes no tests. Please re-check the Upstream Parity row.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

Analysis chain

Script executed:

#!/bin/bash
set -u

echo '=== Port guide ==='
ast-grep outline docs-site/src/content/docs/integrations/browserstack.mdx 2>&1 || true
fd -i '^browserstack\.mdx$' . --exec sh -c 'echo "=== $1 ==="; cat -n "$1"' sh {}

echo '=== Other named provider pages ==='
fd -i '^(e2b|eas|testmu)\.mdx$' . || true

echo '=== PR changed files ==='
gh api --paginate repos/hardkoded/e2e-dotnet/pulls/1564/files --jq '.[] | {filename, status, patch}' 2>&1 || true

echo '=== Upstream commit ==='
gh api repos/tester-army/e2e/commits/220f22c --jq '{sha, files: [.files[] | {filename, status, patch}]}' 2>&1 || true

Length of output: 11137


@kblok I re-checked Upstream Parity: Pass.

  • The PR’s BrowserStack sentence matches upstream commit 220f22c.
  • The upstream commit changes three other provider pages and no tests. The port has no matching pages for those providers.

This is my re-check result. It does not update the saved pre-merge row.


Learnings used

Learnt from: CR
Repo: hardkoded/e2e-dotnet PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-10-31T10:33:19.022Z
Learning: Source excerpt:
# e2e-dotnet

## Porting an upstream change

- When the port adds or changes public API or user-visible behavior, update `skills/e2e-dotnet/SKILL.md` and the guides in `docs-site/src/content/docs/` in the same PR. Regenerate the API reference with `npm run api` from `docs-site/` when public XML documentation changes. Mirror what upstream's `skills/e2e/references/*.md` and `docs/**/*.mdx` say about that member, in the port's C# names.
Learnt from: CR
Repo: hardkoded/e2e-dotnet PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-10-31T10:33:19.022Z
Learning: Source excerpt:
# e2e-dotnet

## Reviewing .NET and C# code

- **Upstream parity.** Check each fix against upstream first. If upstream behaves the same on purpose, report it. Do not "fix" it in the port.

You are interacting with an AI system.

@kblok

kblok commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok

kblok commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 34 minutes.

@kblok
kblok merged commit 0ae258a into main Nov 11, 2026
4 checks passed
@kblok
kblok deleted the docs/1563-hosted-device-requirements branch November 11, 2026 13:31
Ports e2e-inc/e2e#1671 for the one integrations page the port has.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream docs: clarify hosted-device requirements in the BrowserStack guide (#1671)

1 participant