Skip to content

Translate the engine error of every fixture call, not only Browser steps - #1140

Merged
kblok merged 1 commit into
mainfrom
issue-1120-translate-fixture-calls
Nov 5, 2026
Merged

kblok merged 1 commit into
mainfrom
issue-1120-translate-fixture-calls

Conversation

@kblok

@kblok kblok commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

An App call that timed out or lost its session threw the raw engine error, with no runner code and no word on which call it was. Now every fixture call maps the engine error it throws onto the runner taxonomy, as Browser steps already did (#1119): a timeout reads operation timed out in app.open /orders, a lost session is APP_NOT_OPEN. Browser.OnDialogAsync and the download waits now ask for the browser session inside their step, so a missing one is a ConfigurationException, as in GotoAsync.

A missing browser engine in those three calls is now a failed recorded step (it threw before any step existed). A caller's cancel on a web session is CANCELLED and now reads operation cancelled, as upstream's translateEngineError does (see #1121). An OperationCanceledException stays a cancel.

Upstream change ported

e2e-inc/e2e#1505 (bdf769bc270061b93f11847c204a9d40de737bc4): translated(call, body) in packages/e2e/src/run/fixture-recording.ts, which wraps every fixture call. It lives in FixtureRecording.Translated, used by Browser, App, and the device fixtures (EngineFixtureContext.RunOperationAsync, upstream's FixtureRecorder.run).

Partial / skipped tests

  • FixtureRuntime/ExplicitFixtureOperationsTests/Partial_Maps_an_EngineError_a_contributed_method_throws... ports upstream's it of fixture-runtime.test.ts. It is partial: the port has no context.fixture(...) declaration, so the calls go through RunOperationAsync. Upstream's other its of that describe declare fixtures and are not ported.
  • ScreenshotNavigation timeout test: upstream calls the surface; the port goes through App, so it now expects ACTION_FAILED with the engine's OPERATION_TIMEOUT as its cause.
  • AppSteeringHooks/App_open_keeps_the_engines_own_reason_it_cannot_launch now expects ConfigurationException (same code and message), as upstream's category configuration.

.NET-only

  • FixtureRecording (file and class): home for upstream's translated; the port has no FixtureRecorder.
  • Two tests with no upstream it: App_steps_map_the_engine_error... (App records its steps itself here) and Browser_calls_that_need_a_browser_engine_report_a_configuration_error_inside_their_step.
  • Screen and locator steps keep their own mapping (translateLocatorError); not changed.

User-visible message change: COMPATIBILITY.md, SKILL.md, and docs-site/.../migrate/playwright.mdx are updated. No public API change.

Closes #1120

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 46770d7 and 84624fa.

Files selected for processing: 10

  • COMPATIBILITY.md
  • docs-site/src/content/docs/migrate/playwright.mdx
  • skills/e2e-dotnet/SKILL.md
  • src/E2E/Engine/IEngine.cs
  • src/E2E/Run/Browser.cs
  • src/E2E/Run/FixtureRecording.cs
  • src/E2E/Run/Fixtures.cs
  • tests/E2E.Tests/FixtureRuntime/AppSteeringHooksTests.cs
  • tests/E2E.Tests/FixtureRuntime/ExplicitFixtureOperationsTests.cs
  • tests/E2E.Tests/ScreenshotNavigation/SurfaceScreenshotWhileNavigatingTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok
kblok merged commit e8a1193 into main Nov 5, 2026
4 checks passed
@kblok
kblok deleted the issue-1120-translate-fixture-calls branch November 5, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate the engine error of every fixture call, not only Browser steps

1 participant