Skip to content

Run the screenshot tests that waited on #1109 and #1095 - #1117

Merged
kblok merged 2 commits into
mainfrom
issue-1060-screenshot-unignore
Nov 5, 2026
Merged

kblok merged 2 commits into
mainfrom
issue-1060-screenshot-unignore

Conversation

@kblok

@kblok kblok commented Nov 5, 2026

Copy link
Copy Markdown
Member

Two screenshot tests of the Playwright port were [Ignore]d until their defects were fixed. The mask tests waited on #1109 (fixed by #1115) and Should_work_while_navigating waited on #1095 (fixed by #1113). Both now run: the 9 mask tests and the navigation test pass. Should_work_with_Array_deleted stays [Ignore]d for #1110.

No source change, and no new tests: these are the tests of tester-army/e2e apps/testbed/tests/screenshot.e2e.ts that #1111 ported. No new symbols and no public surface change.

Refs #1060

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 9e0ca29 and 871a9aa.

Files selected for processing: 2

  • tests/E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs
  • tests/E2E.NUnit.Tests/Screenshot/PageScreenshotTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok
kblok merged commit aadf261 into main Nov 5, 2026
4 checks passed
@kblok
kblok deleted the issue-1060-screenshot-unignore branch November 5, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant