Skip to content

Throw on inputValue and isChecked of the wrong element; uncheck clicks ARIA radios - #1114

Merged
kblok merged 3 commits into
mainfrom
issue-1094-input-state
Nov 5, 2026
Merged

kblok merged 3 commits into
mainfrom
issue-1094-input-state

Conversation

@kblok

@kblok kblok commented Nov 5, 2026

Copy link
Copy Markdown
Member

InputValueAsync() on a heading used to return "", and IsCheckedAsync() on a button used to return false. Both hid a wrong locator. Now they throw ACTION_FAILED, as Playwright does. A field with no value still reads "", and a checkable role with no state still reads false. UncheckAsync() on a role="radio" now clicks it, as Playwright does; a native radio still refuses.

Breaking: code that relied on "" or false from a node that cannot hold a value or a checked state now gets ACTION_FAILED. This follows upstream's feat!. No public signature changes.

Upstream: e2e-inc/e2e#1552, commit d2556bc.

Ported tests: check-actions (two ARIA radio tests, element and locator target), scripted-reads, locator-basics (inputValue class new, isChecked changed), and the testbed check and locator-convenience tests, which lose their known-difference markers. Upstream's secure-field isChecked assertion is dropped as upstream drops it; the port's own secure-field test drops it too.

.NET-only:

  • NodeStates.CheckedReported: the port reads the checked state as a plain bool, where upstream reads states.checked !== undefined. Checked sets it. The web, mobile, Windows and document engines fill it.
  • Roles.IsValueControl and Roles.IsCheckable map to upstream isValueControl and isCheckable.
  • PageScript.RadioKind is upstream's radioKind.

Docs updated: Locator API reference, errors and Playwright migration guides, the skill writing-tests reference, COMPATIBILITY.md.

Closes #1094

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between bb72ae5 and edf9266.

Files selected for processing: 23

  • COMPATIBILITY.md
  • docs-site/src/content/docs/api/E2E.Engine/NodeStates.md
  • docs-site/src/content/docs/api/E2E/Locator.md
  • docs-site/src/content/docs/docs/index.mdx
  • docs-site/src/content/docs/migrate/playwright.mdx
  • skills/e2e-dotnet/references/writing-tests.md
  • src/E2E.Mobile/SnapshotProjection.cs
  • src/E2E.WinApp/UiaProjection.cs
  • src/E2E/Engine/DocumentEngine.cs
  • src/E2E/Engine/Observation.cs
  • src/E2E/Engine/PageScript.cs
  • src/E2E/Engine/WebEngine.cs
  • src/E2E/Internal/Roles.cs
  • src/E2E/Locator/Screen.cs
  • tests/E2E.NUnit.Tests/Check/PageCheckTests.cs
  • tests/E2E.NUnit.Tests/LocatorConvenience/LocatorConvenienceTests.cs
  • tests/E2E.Tests/CheckActions/ThroughTheElementTargetTests.cs
  • tests/E2E.Tests/CheckActions/ThroughTheLocatorTargetTests.cs
  • tests/E2E.Tests/ExpectAsyncValue/ToHaveValueTests.cs
  • tests/E2E.Tests/LocatorBasics/InputValueTests.cs
  • tests/E2E.Tests/LocatorBasics/IsCheckedAndIsEnabledTests.cs
  • tests/E2E.Tests/ScriptedReads/ScriptedEngineLocatorReadsAndQueriesTests.cs
  • tests/E2E.Tests/ScriptedScreen/ScriptedScene.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok
kblok merged commit 13738a0 into main Nov 5, 2026
5 of 6 checks passed
@kblok
kblok deleted the issue-1094-input-state branch November 5, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream: inputValue and isChecked throw on the wrong element, uncheck clicks ARIA radios (#1552)

1 participant