Skip to content

Port Playwright's keyboard tests - #1085

Merged
kblok merged 17 commits into
mainfrom
issue-1060-input-pages-3
Nov 5, 2026
Merged

kblok merged 17 commits into
mainfrom
issue-1060-input-pages-3

Conversation

@kblok

@kblok kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member

Ports Playwright's keyboard tests (group B of #1060), the last of the input pages: typing, key codes, modifiers, shortcuts, and keys inside shadow DOM and iframes. All 48 pass without a known-difference marker. The testbed also listens on localhost now, the second origin of the cross-origin test.

Upstream change ported: e2e-inc/e2e#1505, commit bdf769b.

Ported (playwright category): keyboard.e2e.ts, 48 it (Keyboard/PageKeyboardTests). The two macOS-only tests use Assume and run only on macOS, as upstream's test.skip(!isMac). Upstream's three expect.soft blocks (location, key, code) are Assert.Multiple. Not ported, as upstream: should send a character with insertText, insertText should only emit input event (no keyboard.insertText); should expose keyIdentifier in webkit (WebKit only); should dispatch insertText after context menu was opened, should type after context menu was opened (mouse.down presses only the primary button).

.NET-only: Helpers.CROSS (upstream's CROSS) and the localhost prefix of the testbed listener. COMPATIBILITY.md lists the ported file. No change to src/, so no SKILL.md or docs change.

Refs #1060. Stacked on #1064: retarget to main after it merges.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

kblok and others added 7 commits November 4, 2026 18:40
…t tests (Refs #1060)

The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…r tests (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…B chunks (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…iew tests (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ee824be and c81d991.

Files selected for processing: 3

  • COMPATIBILITY.md
  • tests/E2E.NUnit.Tests/Keyboard/PageKeyboardTests.cs
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/keyboard.html
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Fixed: removed the unused Asset helper from this PR (PR 1069 adds and uses it). Declined: the localhost prefix and CROSS derivation (loopback needs no ACL, same as 127.0.0.1); Assume for the two macOS tests (upstream skips on the host platform too; they ran here); the ! in the two read helpers; the LastKeydown record (the test passes, so the serializer binds it).

@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Base automatically changed from issue-1060-playwright-page-tests to main November 4, 2026 22:24
kblok and others added 5 commits November 4, 2026 19:28
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…is fixed on main (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok
kblok merged commit 0fcf01f into main Nov 5, 2026
4 checks passed
@kblok
kblok deleted the issue-1060-input-pages-3 branch November 5, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant