Skip to content

Port Playwright's selectors and locator page tests (80 tests, Refs #1060) - #1077

Merged
kblok merged 3 commits into
mainfrom
issue-1060-selectors
Nov 4, 2026
Merged

kblok merged 3 commits into
mainfrom
issue-1060-selectors

Conversation

@kblok

@kblok kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member

Second slice of Playwright's page tests (group A of #1060): the selector and locator files that only need /content and a few assets. 80 tests run against the testbed with a real browser, in the playwright category. They are stacked on #1064 and add four assets (dom.html, offscreenbuttons.html, frames/two-frames.html with its frame.html, script.js, style.css).

Porting them found real differences in the web engine. Each is a test that keeps upstream's assertions behind ExpectedToFailAsync, or [Ignore] where it uses expect.soft, and has its own issue (#1072 to #1076).

Upstream change ported: e2e-inc/e2e#1505, commit bdf769b, apps/testbed/tests/:

  • selectors-get-by.e2e.ts: 19 of 19 it, SelectorsGetBy/SelectorsGetByTests
  • selectors-role.e2e.ts: 15 of 15, SelectorsRole/SelectorsRoleTests
  • locator-is-visible.e2e.ts: 10 of 10, LocatorIsVisible/LocatorIsVisibleTests
  • locator-convenience.e2e.ts: 7 of 7, LocatorConvenience/LocatorConvenienceTests
  • locator-misc-2.e2e.ts: 10 of 10, LocatorMisc2/LocatorMisc2Tests
  • locator-query.e2e.ts: 19 of 19, LocatorQuery/LocatorQueryTests

Known differences (upstream passes, the port does not yet):

Upstream fail: tests (kept behind ExpectedToFailAsync, as upstream): InputValue_should_work, TextContent_should_work, IsChecked_should_work, Locator_count_should_work_with_deleted_Map_in_main_world.

Not ported, as upstream: the tests that need features e2e lacks, listed in the header of each class (for example innerHTML, describe(), and(), within(), getByAltText, getByTitle, getByRole description).

Adapted: .NET regexes have no g, y or v flags, so GetByRole_should_accept_regexp_with_v_flag and Locators_should_not_be_affected_by_global_and_sticky_regex_flags use plain patterns.

.NET-only symbols: none in src/. Test helper LabelsAsync, Joined and ExpectErrorAsync are private to their classes.

Refs #1060

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

kblok and others added 3 commits November 4, 2026 18:40
…t tests (Refs #1060)

The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 108b3ed and d4d60e5.

Files selected for processing: 26
  • COMPATIBILITY.md
  • tests/E2E.Agent.Tests/PlaywrightRoutes.cs
  • tests/E2E.Agent.Tests/Testbed.cs
  • tests/E2E.NUnit.Tests/Check/PageCheckTests.cs
  • tests/E2E.NUnit.Tests/E2E.NUnit.Tests.csproj
  • tests/E2E.NUnit.Tests/Helpers/Helpers.cs
  • tests/E2E.NUnit.Tests/LocatorConvenience/LocatorConvenienceTests.cs
  • tests/E2E.NUnit.Tests/LocatorIsVisible/LocatorIsVisibleTests.cs
  • tests/E2E.NUnit.Tests/LocatorList/LocatorListTests.cs
  • tests/E2E.NUnit.Tests/LocatorMisc2/LocatorMisc2Tests.cs
  • tests/E2E.NUnit.Tests/LocatorQuery/LocatorQueryTests.cs
  • tests/E2E.NUnit.Tests/SelectorsGetBy/SelectorsGetByTests.cs
  • tests/E2E.NUnit.Tests/SelectorsRole/SelectorsRoleTests.cs
  • tests/E2E.NUnit.Tests/SelectorsText/SelectorsTextTests.cs
  • tests/E2E.NUnit.Tests/Testbed/playwright/LICENSE
  • tests/E2E.NUnit.Tests/Testbed/playwright/NOTICE
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/dom.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/empty.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/frames/frame.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/frames/script.js
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/frames/style.css
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/frames/two-frames.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/grid.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/offscreenbuttons.html
  • tests/E2E.NUnit.Tests/WaitForUrl/PageWaitForUrlTests.cs
  • tests/E2E.XUnit.V3.Tests/E2E.XUnit.V3.Tests.csproj
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Base automatically changed from issue-1060-playwright-page-tests to main November 4, 2026 22:24
@kblok
kblok merged commit 4b3025f into main Nov 4, 2026
4 checks passed
@kblok
kblok deleted the issue-1060-selectors branch November 4, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant