Repository navigation
Port Playwright's selectors and locator page tests (80 tests, Refs #1060) - #1077
Merged
Merged
Conversation
…t tests (Refs #1060) The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second slice of Playwright's page tests (group A of #1060): the selector and locator files that only need
/contentand a few assets. 80 tests run against the testbed with a real browser, in theplaywrightcategory. They are stacked on #1064 and add four assets (dom.html,offscreenbuttons.html,frames/two-frames.htmlwith itsframe.html,script.js,style.css).Porting them found real differences in the web engine. Each is a test that keeps upstream's assertions behind
ExpectedToFailAsync, or[Ignore]where it usesexpect.soft, and has its own issue (#1072 to #1076).Upstream change ported: e2e-inc/e2e#1505, commit
bdf769b,apps/testbed/tests/:selectors-get-by.e2e.ts: 19 of 19it,SelectorsGetBy/SelectorsGetByTestsselectors-role.e2e.ts: 15 of 15,SelectorsRole/SelectorsRoleTestslocator-is-visible.e2e.ts: 10 of 10,LocatorIsVisible/LocatorIsVisibleTestslocator-convenience.e2e.ts: 7 of 7,LocatorConvenience/LocatorConvenienceTestslocator-misc-2.e2e.ts: 10 of 10,LocatorMisc2/LocatorMisc2Testslocator-query.e2e.ts: 19 of 19,LocatorQuery/LocatorQueryTestsKnown differences (upstream passes, the port does not yet):
getByTextreturns the control of a label and matches a placeholder (GetByLabel_should_work,Locators_should_not_be_affected_by_global_and_sticky_regex_flags;GetBy_escapingis[Ignore]).Should_filter_by_regex_with_a_single_quote,[Ignore]).Should_filter_by_regex_with_special_symbols).LocatorIsVisibletests).getByRolemixed and absent states,aria-level(Should_support_checked,_pressed,_expanded,_level).Upstream
fail:tests (kept behindExpectedToFailAsync, as upstream):InputValue_should_work,TextContent_should_work,IsChecked_should_work,Locator_count_should_work_with_deleted_Map_in_main_world.Not ported, as upstream: the tests that need features e2e lacks, listed in the header of each class (for example
innerHTML,describe(),and(),within(),getByAltText,getByTitle,getByRoledescription).Adapted: .NET regexes have no
g,yorvflags, soGetByRole_should_accept_regexp_with_v_flagandLocators_should_not_be_affected_by_global_and_sticky_regex_flagsuse plain patterns..NET-only symbols: none in
src/. Test helperLabelsAsync,JoinedandExpectErrorAsyncare private to their classes.Refs #1060
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK