Repository navigation
Port Playwright's route, request-fallback and request-fulfill tests (Refs #1060) - #1071
Conversation
…t tests (Refs #1060) The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nd the rest of routes.mjs (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
Review round: fixed |
…utes # Conflicts: # tests/E2E.Agent.Tests/PlaywrightRoutes.cs # tests/E2E.Agent.Tests/Testbed.cs # tests/E2E.NUnit.Tests/Helpers/Helpers.cs
|
@coderabbitai review |
Action not completed
|
…utes # Conflicts: # tests/E2E.Agent.Tests/PlaywrightRoutes.cs # tests/E2E.Agent.Tests/Testbed.cs # tests/E2E.NUnit.Tests/Helpers/Helpers.cs
|
@coderabbitai review |
Action not completed
|
…utes # Conflicts: # tests/E2E.Agent.Tests/PlaywrightRoutes.cs # tests/E2E.Agent.Tests/Testbed.cs
|
@coderabbitai review |
Action not completed
|
Tests that hold, redirect or answer requests need a test server that does more than serve files. This PR ports the rest of upstream's
routes.mjs(/echo,/status,/slow,/never,/redirect,/download,/set-cookie,/respond,/cors-echo,/bounce,/count,/options,/options-log,/upload,/binary,/download-stall,/sse, and the/wsupgrade) into the testbed, and ports three network test files on top of it. The testbed now also listens onlocalhost(the cross-originCROSShost) and serves these routes without blocking its accept loop, because several of them hold a request open.Stacked on #1064 (base is its branch until it merges).
Upstream change ported
tester-army/e2e#1505, commitbdf769b:apps/testbed/app/playwright/routes.mjs,route.e2e.ts(39it+ the 4-method loop),request-fallback.e2e.ts(6),request-fulfill.e2e.ts(16). DirectoriesRoute/,RequestFallback/,RequestFulfill/, one class perdescribe. The other group D files follow in the next PR.Not ported
Each is named in the class summary, as upstream's "Not ported" header: dataURL goto,
setExtraHTTPHeaders,abort(errorCode),fallback({ ... }),times,allHeaders(),request.response(), service workers, URLPattern, WebKit-only, buffer/response/HAR/gzip fulfill,headerValueset-cookie.fail): "should not support ? in glob pattern" (?in a route glob matches one character), viaExpectedToFailAsync.[Ignore], as upstreamskip: "should fulfill with multiple set-cookie" and "should fulfill with fetch response that has multiple set-cookie" (fulfillrefuses a newline in a header value).responseoption..NET-only symbols
Helpers:CROSS,Asset,Deferred,WithHeaders,Served,Contain,AllAsync(test helpers forPromise.all,{ ...headers },/cors-echoJSON).Testbed.ServePlaywrightRoutesAsync: runs each route off the accept loop (HttpListener is a single loop).PlaywrightRoutes.HeldRequestLimit: HttpListener has no close event, so/never,/sse,/download-stalland/wsrelease after 2 minutes.PlaywrightRoutes.UpgradeAsyncis upstream'supgrade, called fromHandleAsyncsince HttpListener has one entry point.No
src/change, so no real-model run and no docs change.Refs #1060
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK