Skip to content

Port Playwright's fill, select-option, set-input-files and filechooser tests - #1069

Merged
kblok merged 6 commits into
mainfrom
issue-1060-input-pages-1
Nov 4, 2026
Merged

kblok merged 6 commits into
mainfrom
issue-1060-input-pages-1

Conversation

@kblok

@kblok kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member

Ports the first four input-page test files of Playwright's page tests (group B of #1060): the form controls. They run against the playground with Playwright's input assets. The playground now answers /respond and /upload (a multipart form comes back as JSON, as upstream's route) and also listens on localhost, the second origin of the cross-origin cases.

Upstream change ported: e2e-inc/e2e#1505, commit bdf769b.

Ported (playwright category, one directory per upstream file, one class per describe):

  • fill.e2e.ts: 39 it (Fill/PageFillTests). The 7 generated input event.composed ... cases are [TestCase]s. Not ported, as upstream: should throw if passed a non-string value.
  • select-option.e2e.ts: 17 it (SelectOption/PageSelectOptionTests). Not ported, as upstream: the 16 tests that need arrays, handles, or several attributes. Upstream marks "should select single option" as fail; the port matches a bare string by value or label, so it passes and has no marker.
  • set-input-files.e2e.ts: 18 it (SetInputFiles/PageSetInputFilesTests). Not ported, as upstream: should set from memory, input event.composed ... (payloads). "should throw an error if the file does not exist" checks .NET's Could not find file where upstream checks Node's ENOENT.
  • filechooser.e2e.ts: 6 it (Filechooser/PageFilechooserTests). "should be able to reset selected files with empty file list" is [Ignore]d, as upstream's skip: SetInputFilesAsync([]) is refused.

.NET-only: Helpers.CROSS (upstream's CROSS, from the testbed port) and Helpers.Asset (upstream's asset), in the test helpers; PlaywrightRoutes gets upstream's /respond and /upload.

COMPATIBILITY.md lists the ported files. No change to src/, so no SKILL.md or docs change.

Refs #1060. Stacked on #1064: retarget to main after it merges.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

kblok and others added 3 commits November 4, 2026 18:40
…t tests (Refs #1060)

The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…r tests (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 4b3025f and 8fe7f84.

Files ignored due to path filters: 1
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/pptr.png is excluded by !**/*.png
Files selected for processing: 17
  • COMPATIBILITY.md
  • tests/E2E.Agent.Tests/PlaywrightRoutes.cs
  • tests/E2E.Agent.Tests/Testbed.cs
  • tests/E2E.NUnit.Tests/Filechooser/PageFilechooserTests.cs
  • tests/E2E.NUnit.Tests/Fill/PageFillTests.cs
  • tests/E2E.NUnit.Tests/Helpers/Helpers.cs
  • tests/E2E.NUnit.Tests/SelectOption/PageSelectOptionTests.cs
  • tests/E2E.NUnit.Tests/SelectorsText/SelectorsTextTests.cs
  • tests/E2E.NUnit.Tests/SetInputFiles/PageSetInputFilesTests.cs
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/file to upload.txt
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/file-to-upload-2.txt
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/file-to-upload.txt
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/fileupload-multi.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/fileupload.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/folderupload.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/select.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/textarea.html
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…B chunks (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Fixed: malformed status/multipart no longer throw in the routes; large files are written in 1MB chunks; teardown checks the directory exists. Declined: the Task.Run flag pattern (same as the merged-slice tests and upstream's shape); the localhost prefix (loopback prefixes need no ACL, same as 127.0.0.1); shared helper extraction (upstream repeats these per file).

@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Base automatically changed from issue-1060-playwright-page-tests to main November 4, 2026 22:24
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…is fixed on main (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Also removed the ExpectedToFailAsync marker of the selectors-text test (#1062 is fixed on main, the test passed unexpectedly). Playwright category on this head: all pass. @coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

@kblok I’ll request a review of the latest changes, including the removal of ExpectedToFailAsync. Thanks for confirming that the Playwright category passes on this head.

Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok
kblok merged commit 72f4f6e into main Nov 4, 2026
4 checks passed
@kblok
kblok deleted the issue-1060-input-pages-1 branch November 4, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant