Repository navigation
Port Playwright's fill, select-option, set-input-files and filechooser tests - #1069
Conversation
…t tests (Refs #1060) The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…r tests (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…B chunks (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
Fixed: malformed status/multipart no longer throw in the routes; large files are written in 1MB chunks; teardown checks the directory exists. Declined: the Task.Run flag pattern (same as the merged-slice tests and upstream's shape); the |
|
@coderabbitai review |
Action not completed
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
…is fixed on main (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
Also removed the |
|
Action not completed
|
Ports the first four input-page test files of Playwright's page tests (group B of #1060): the form controls. They run against the playground with Playwright's input assets. The playground now answers
/respondand/upload(a multipart form comes back as JSON, as upstream's route) and also listens onlocalhost, the second origin of the cross-origin cases.Upstream change ported: e2e-inc/e2e#1505, commit
bdf769b.Ported (
playwrightcategory, one directory per upstream file, one class perdescribe):fill.e2e.ts: 39it(Fill/PageFillTests). The 7 generatedinput event.composed ...cases are[TestCase]s. Not ported, as upstream: should throw if passed a non-string value.select-option.e2e.ts: 17it(SelectOption/PageSelectOptionTests). Not ported, as upstream: the 16 tests that need arrays, handles, or several attributes. Upstream marks "should select single option" asfail; the port matches a bare string by value or label, so it passes and has no marker.set-input-files.e2e.ts: 18it(SetInputFiles/PageSetInputFilesTests). Not ported, as upstream: should set from memory, input event.composed ... (payloads). "should throw an error if the file does not exist" checks .NET'sCould not find filewhere upstream checks Node'sENOENT.filechooser.e2e.ts: 6it(Filechooser/PageFilechooserTests). "should be able to reset selected files with empty file list" is[Ignore]d, as upstream'sskip:SetInputFilesAsync([])is refused..NET-only:
Helpers.CROSS(upstream'sCROSS, from the testbed port) andHelpers.Asset(upstream'sasset), in the test helpers;PlaywrightRoutesgets upstream's/respondand/upload.COMPATIBILITY.md lists the ported files. No change to
src/, so no SKILL.md or docs change.Refs #1060. Stacked on #1064: retarget to
mainafter it merges.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK