Repository navigation
Run the slow last read tests on a fake clock - #1029
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Member
Author
|
@coderabbitai review |
Contributor
Action not completed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a slow last readraced a realStopwatchagainst real 350 ms waits. On a loaded runner the banner time and the last read drifted apart, andwaitFortimed out with "matched 0 nodes". The two tests now run on the stepping fake clock: each read moves the clock by 350 ms, so the banner shows at 1050 ms of fake time and the last read (which ends at 1150 ms) sees it. Both tests now take about 25 ms.Most other tests in the issue were already made deterministic by earlier PRs (#930, #956, #950, #893 and others). Their runs were from before those merged. I ran each remaining test 100 times with 4 parallel processes on current main plus this change: no failure in the clock-based tests.
Upstream change ported: none. The tests keep the names and layout of upstream's
a slow last read(tester-army/e2elocator-wait-fortests). No new symbols, no public API change.Not covered (issue stays open):
ManagedProcessTests.Cancels_an_in_flight_readiness_probe(startup)fails when the spawned app exits with code 137 (known sandbox failure). It does not race a deadline, so a fake clock does not help. It needs a separate look on a real CI runner.ToHaveScreenshotTestsstill has one real 1100 ms delay against a 1 s budget in a neighbouring test (not in the issue).Refs #1006
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK