Repository navigation
Extract LocatorEngine so its upstream tests port as written - #1002
Merged
Merged
Conversation
The retries, deadlines, resolve, and the operation context a call carries lived in Screen and Locator. They now live in LocatorEngine (locator/engine.ts upstream), which Screen and Locator hand their query. Behavior is unchanged. The origin test, the missing resolve, and the reads that do not wait now port from locator-engine.test.ts without Partial_ where the port has the call. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Member
Author
|
@coderabbitai review |
Contributor
Action not completed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retries, deadlines, resolves, and the context a call carries lived in
ScreenandLocator, so upstream'slocator-engine.test.tscould not run against an engine. They now live inLocatorEngine(Locator/LocatorEngine.cs), andScreenandLocatorhand it their query. No behavior changes. The origin test now checks the origin at the engine that adds it, so it is no longerPartial_.Upstream parity
Upstream change ported:
LocatorEngineand its tests, tester-army/e2epackages/e2e/src/locator/engine.tsandpackages/e2e/tests/unit/locator-engine.test.ts, last changed in79e2e13d3365(e2e-inc/e2e#1416), read at50fa7afc1a6f.Tests (
LocatorEngine/): the originitis whole. New whole ports: five resolve retry its, the reads that do not wait (resolveNow, readNow, readAllNow),isNodeVisible, and the two visible-query its that hand a query to the engine.ScriptedLocatorEngineis upstream'smakeEngine.Partial:
Partial_ReadNow_re_resolves_after_a_stale_resolve_...andPartial_Reads_every_current_match_...countsession.readcalls, which the port does not have (a locate answers the nodes).Not ported: the its that need
session.readto go stale (read retry 1 to 3, read contract, readAllNow stale and failure, readNow stale between resolve and read),secret fill(no enginefillSecret),AttemptBudget.capped(noAttemptBudget), the cross-realm describe (.NET has no second module registry), andlocator failure candidate counts(not in the port yet: #1001)..NET-only symbols:
LocatorEngineOptions: the session as a set of calls, since the attempt reads the screen through its scope and a test builds an engine from functions.LocatorEngine.DeadlineFor: upstream'sdeadline;Deadlineis the type's name.LocatorEngine.TimeoutOf,SessionPerformAsync,SessionPerformAtAsync: the session seam, used byScreenand the screenshot code.LocatorEngine.ResolveOnceAsyncalso resolves over an observation for an engine with no locate.NET_only_a_session_wires_the_test_origin_to_the_engine_a_test_acts_onkeeps the oldE2ESessionwiring check.Known gaps, unchanged by this PR:
PerformUntilAsyncrecords no event andPerformAsyncchecks the node is enabled (upstream has oneperformUntil);screen.swipestill gets its context inE2ESession.COMPATIBILITY.mdis updated. The public API is unchanged, soSKILL.mdand the docs-site need no edit.Closes #994
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK