Skip to content

Port mayTakeText/takesText: refuse fill and clear on non-input roles (upstream #1427) #850

Closed

Description

@kblok

Left over from #742 (upstream e2e-inc/e2e#1427, commit 75ae2ab). The placeholder fold is ported in #849. This is the other half.

Upstream fill and clear (surface.ts) refuse a node that is not a text input with UNSUPPORTED_CAPABILITY. The commit widens that check with mayTakeText (nodes.ts): an iOS other that holds a value, or only static text, may take text, since a custom-drawn Compose Multiplatform or Flutter field reads that way. It also adds NodeBinding.takesText, checked before the action and again after the relocation.

The port has no such check: DeviceActions sends fill and clear to any node with a ref. To port it, add the refusal as upstream has it (including the re-check after relocation), then port the three its of describe('input freshness') in engine.test.ts: "acts on an unclassified iOS field", "rejects an unclassified iOS element", "rejects an unclassified iOS element that gained a control before typing". Mirror the fill/clear sentences of upstream docs/reference/mobile.mdx and skills/e2e/references/setup.md.

Adding the refusal is a behavior change: fill on a button or text would start failing.

Activity

  1. kblok commented on Oct 31, 2026

    @kblok
    MemberAuthor

    An agent is working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions