Skip to content

Core signals: mark engine-owned signal listeners (engineListeners, upstream core/signals.ts) #1704

Closed as not planned

Description

@kblok

Follow-up of #1677. Upstream's engineListeners() marks signal listeners an engine registers while a host or session opens, so they neither hold the process nor swallow the signal. The port cannot list PosixSignalRegistrations, so an engine's own listener is not told from the program's; the engine-listens half of core-signals.test.ts 'ends by SIGHUP though the engine listens for it...' is not ported (port test: Partial_ends_by_SIGHUP_...). Upstream also raises the signal again itself; the port lets the runtime's default action end the process.


Generated by Claude Code

Activity

  1. kblok commented on Nov 16, 2026

    @kblok
    MemberAuthor

    QUESTION: This builds on Signals.cs from PR #1702, which is still open and unmerged, so main has no signal code to extend. How should I proceed?

    1. Wait until Close the host on SIGINT, SIGTERM, and SIGHUP (core-signals) #1702 merges, then branch from main (recommended: no stacked PR, no rebase churn).
    2. Stack this work on fix/1677-core-signals-port and open the PR against that branch.

    Also note .NET cannot list PosixSignalRegistrations, so engineListeners needs a .NET-only mechanism (e.g. an engine-side registration wrapper). I will match upstream's names and put the .NET-only part in the PR report.


    Generated by Claude Code

  2. kblok commented on Nov 16, 2026

    @kblok
    MemberAuthor

    Closing on the owner's request. No work was done here; it depended on the unmerged signals port in #1702.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions