Skip to content

Agent tools: fill_secret takes secret, upstream type_secret takes name #1646

Closed

Description

@kblok

Follow-up of #1642. Upstream's type_secret takes target (an id) and name (the secret). The port's target is a flat object with role, name, testId, ref, so name collides and the port keeps secret. Matching upstream needs the node target reshaped. Tool names (fill, fill_secret for type, type_secret) also differ. The MCP catalog's type_secret description is still fixed text.


Generated by Claude Code

Activity

  1. kblok commented on Nov 14, 2026

    @kblok
    MemberAuthor

    QUESTION: This needs #1644 (nodes addressed by one target id) first, and #1645 (tool renames) is still open, so should I do #1644 in this PR?

    1. Do Agent tools: address nodes by a single target id, as upstream #1644 and Agent tools: fill_secret takes secret, upstream type_secret takes name #1646 together in one PR: reshape every node tool to target (id), then rename fill/fill_secret to type/type_secret and secret to name.
    2. Wait for Name the agent tools as upstream and port the default toolset test on the web engine (#1630) #1645 to merge, then do Agent tools: address nodes by a single target id, as upstream #1644, then this issue as a separate PR.
      Recommendation: 2. Both change the same tool schemas, and the real-model tests would run once per change.

    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions