Skip to content

Translate the engine error of every fixture call, not only Browser steps #1120

Closed

Description

@kblok

Upstream's fixture runtime (translated(call, body) in packages/e2e/src/run/fixture-recording.ts, e2e-inc/e2e#1505 bdf769bc270061b93f11847c204a9d40de737bc4) maps the engine error of every fixture call onto the runner taxonomy, with in <api> <label> as the suffix. PR #1119 does this only for Browser steps (Browser.Translated).

Left to do:

  • App steps and every other fixture step (Fixtures.cs RunStepAsync) still throw the raw EngineException, with no ACTION_FAILED mapping and no in app.open suffix.
  • Browser.OnDialogAsync, WaitForDownloadAsync and WaitForDownloadsAsync call Require() before RunStepAsync, so a missing capability there is a raw EngineException and not a ConfigurationException, unlike GotoAsync.
  • Check with upstream whether a caller's cancel (CANCELLED from the engine) should stay a cancel here; upstream maps it to operation cancelled.

Refs #1119, #1068.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions