Skip to content

goto timeout message has no 'timed out in browser.goto' label (frame-goto, #1060) #1068

Closed

Description

@kblok

Found while porting upstream's frame-goto.e2e.ts (tester-army/e2e bdf769b, #1060).

Upstream's should continue after client redirect expects a browser.goto(url, { timeout: 5000, waitUntil: 'networkidle' }) that times out to fail with a message that contains timed out in browser.goto. In the port the message is:

goto http://127.0.0.1:<port>/frames/child-redirect.html: Timeout 4750ms exceeded.

The upstream commit adds a translated(call, ...) timeout message (with a unit test in fixture-runtime.test.ts) and a patternLabel step label; the port does not have them yet (planned as its own PR in the #1060 plan). The test needs the message, not the timeout itself, so it is kept behind the ExpectedToFailAsync helper until the label is ported.

Activity

  1. kblok commented on Nov 4, 2026

    @kblok
    MemberAuthor

    Same missing label seen in the waitForResponse case: upstream's Should_log_the_url (PR #1083) expects the timeout message to name the pattern, and the port's message does not. The test runs under ExpectedToFailAsync until the label change lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions