Skip to content

Port the candidate counts of a failed filtered locator (upstream candidateCounts) #1001

Closed

Description

@kblok

Upstream shows how many candidates each filter step of a locator left when the locator matches nothing or too many (candidateCounts in packages/e2e/src/locator/engine.ts, e2e-inc/e2e#1416, commit 79e2e13d3365). The failure message gets a candidates left after each filter step, counted after the failure: list, bounded by one 500 ms diagnostic budget.

The port has no such list. LocatorEngine (#994) is the place for it: ResolveCountedAsync and TryReadAsync would call a CandidateCounts method as upstream does. Port the six locator failure candidate counts its of locator-engine.test.ts with it.

Found while extracting LocatorEngine.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions