Repository navigation
Make bare URLs in native Markdown clickable - #1282
Draft
IshmeetSingh06 wants to merge 3 commits into
Draft
IshmeetSingh06 wants to merge 3 commits into
IshmeetSingh06 wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Bare URLs,
www.addresses and email addresses in native Markdown now render as links, in prose, lists, headings, table cells and emphasis, matching the React app's GFM autolinks.www.opens overhttp://and emails overmailto:, as they do there. Code, image alt text and explicit Markdown links are unchanged. Trailing sentence punctuation stays out of the link, and consecutive text events are merged first so URLs containing_or&stay whole.<me@a.com>also gets its missingmailto:.Why
pulldown-cmarkonly produces links for[text](url)and<url>, so a plain URL from an agent was unclickable in the GPUI app, unlike the React app.Compared with
remark-gfmon 123 samples, 109 match. Remaining differences are deliberate or rare: native stops at CJK punctuation, uses decoded URLs for entities and escapes, and doesn't link uppercase schemes such asHTTPS://.UI
Screenshots to be added.
Checklist
npm run checkNot run:
npm run check.npm run native:teston the final commit:monocode-core653 passed;monocode-gpui796 passed, 1 failed. The failure iswheel_glide_tests::wheel_notches_glide_and_trackpad_pixels_land_at_once, which fails the same way without this change. Clippy is clean, and bare URLs,www.addresses and emails were checked in the app.cargo fmt --checkalso flagssrc/main.rsandtests/review_wheel_tmp.rs, which this PR leaves alone.🤖 Generated with Claude Code