Skip to content

Make bare URLs in native Markdown clickable - #1282

Draft
IshmeetSingh06 wants to merge 3 commits into
hardbeat920:mainfrom
IshmeetSingh06:fix/native-bare-url-links
Draft

IshmeetSingh06 wants to merge 3 commits into
hardbeat920:mainfrom
IshmeetSingh06:fix/native-bare-url-links

Conversation

@IshmeetSingh06

@IshmeetSingh06 IshmeetSingh06 commented Nov 1, 2026 •

Copy link
Copy Markdown

What changed

Bare URLs, www. addresses and email addresses in native Markdown now render as links, in prose, lists, headings, table cells and emphasis, matching the React app's GFM autolinks. www. opens over http:// and emails over mailto:, as they do there. Code, image alt text and explicit Markdown links are unchanged. Trailing sentence punctuation stays out of the link, and consecutive text events are merged first so URLs containing _ or & stay whole. <me@a.com> also gets its missing mailto:.

Why

pulldown-cmark only produces links for [text](url) and <url>, so a plain URL from an agent was unclickable in the GPUI app, unlike the React app.

Compared with remark-gfm on 123 samples, 109 match. Remaining differences are deliberate or rare: native stops at CJK punctuation, uses decoded URLs for entities and escapes, and doesn't link uppercase schemes such as HTTPS://.

UI

Screenshots to be added.

Checklist

  • I ran npm run check
  • This PR is small and focused
  • I did not mix unrelated changes

Not run: npm run check. npm run native:test on the final commit: monocode-core 653 passed; monocode-gpui 796 passed, 1 failed. The failure is wheel_glide_tests::wheel_notches_glide_and_trackpad_pixels_land_at_once, which fails the same way without this change. Clippy is clean, and bare URLs, www. addresses and emails were checked in the app. cargo fmt --check also flags src/main.rs and tests/review_wheel_tmp.rs, which this PR leaves alone.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

IshmeetSingh06 and others added 2 commits November 1, 2026 22:28
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant