Skip to content

deps: point ggml to Adreno fused qknorm rope#4

Open
happyyzy wants to merge 1 commit into
agent/sdcpp-ggml-xmem-sdpafrom
agent/sdcpp-ggml-fused-qknorm-rope
Open

deps: point ggml to Adreno fused qknorm rope#4
happyyzy wants to merge 1 commit into
agent/sdcpp-ggml-xmem-sdpafrom
agent/sdcpp-ggml-fused-qknorm-rope

Conversation

@happyyzy

Copy link
Copy Markdown
Owner

Summary

Updates the ggml submodule pointer to the local staging branch with the fused Adreno qknorm/RoPE OpenCL path.

Corresponding ggml PR: happyyzy/ggml#1.

Notes

This PR is stacked on #3 and only updates the dependency pointer.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9986d486b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ggml
@@ -1 +1 @@
Subproject commit 399ea717940d2008e70ead58a992b83d0745569f
Subproject commit 765887922710717e15892b6d5207a22eef74abd3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Point ggml at a fetchable commit

This updates the ggml gitlink to 7658879, but .gitmodules still fetches the submodule from https://github.com/leejet/ggml.git; that repository does not contain this commit while it exists in the happyyzy/ggml fork referenced by the commit message. In a fresh checkout, git submodule update --init ggml will fail unless the user already has that object locally, so builds from this revision cannot reliably fetch dependencies. Please either push/merge the ggml commit to the configured submodule remote or update the submodule URL to a remote that contains it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant