fix #902, fix alpha scale for CSS rgba#905
Merged
Merged
Conversation
dmurdoch
reviewed
May 22, 2025
Contributor
Author
There was a problem hiding this comment.
b/c the tests required it for some reason, I thought any packages needed for devtools::test() and not for the package itself should be in Suggests:.
Contributor
Author
There was a problem hiding this comment.
Said differently, nothing in my patch requires it, but the package would not pass a test without it. Frankly, the side-effect of opening browser windows while running the test seemed non-standard as well ...
I just ran ::check() and it's complaining about not having formattable and sparkline needed for the vignettes, which seems like they should also be in Suggests. I'll just trust that y'all will handle all of the dependencies, even if it doesn't build or check correctly on my machine.
Collaborator
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.