Skip to content

fix(chat): Effort and Mode lists open where they can be seen - #327

Merged
Darkhorse7stars merged 1 commit into
mainfrom
fix/effort-popover
Nov 20, 2026
Merged

Darkhorse7stars merged 1 commit into
mainfrom
fix/effort-popover

Conversation

@jamessburnss1313-dev

Copy link
Copy Markdown
Contributor

Bug

On hanzo.app/chat, clicking Effort does nothing. The list opens but is never placed: it sits at the top-left at opacity 0. Mode on Dev has the same bug. Model works. The bug came in with #326.

Cause

Tooltip and Popover share the empty scope, and a Tooltip provides its own Popper and Popover context (@hanzogui/tooltip Tooltip.tsx:232-251). In Opens() the Tooltip sat between Popover and PopoverTrigger, so the trigger anchored the Tooltip, and the Popover content never got an anchor.

Fix

Opens() now nests the Popover inside the TooltipTrigger, the same structure Pick() uses for the Model picker. It is one shape for all three controls. No other place in ui has the old shape: gallery.tsx and gallery/menus.tsx keep the two side by side.

Test

test:composer now opens Effort (and Mode on Dev) at every width and theme. It requires a list that is seen on screen, beside its word on desktop, and gone after Escape.

  • Without the fix: 24 failures (seen:false at 7,7, matching live).
  • With the fix: every case passes.

Checks

  • vitest chat, models and rtl: 288 passed.
  • tsc: same count as main, nothing new in Tune.tsx.
  • An independent reviewer confirmed the cause in the hanzogui sources.

Tooltip and Popover share the empty scope, and a Tooltip provides its own Popper
and Popover context. With the Tooltip between Popover and PopoverTrigger, the
trigger anchored the Tooltip and the Popover content was never placed: it stayed
at the top-left at opacity 0. Nest the Popover inside the TooltipTrigger, as the
Model picker does.

test:composer opens Effort (and Mode on Dev) at every width and requires a list
that is seen on screen, beside its word on desktop, and gone after Escape.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-20T12:34:51.770859Z
We couldn’t complete this review. Comment @codex review to try again.
ec05f47 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@Darkhorse7stars
Darkhorse7stars merged commit a048251 into main Nov 20, 2026
21 checks passed
@Darkhorse7stars
Darkhorse7stars deleted the fix/effort-popover branch November 20, 2026 19:47
Darkhorse7stars added a commit that referenced this pull request Nov 20, 2026
… Mode titled on the row (#328)

Releases #327 (the Effort and Mode lists open where they can be seen,
hanzo-inc/app#444) and holds the row's titles in place (hanzo-inc/app#313).

The closed words already read as their title over (or beside, on a phone)
their value since 8.33.5: "Model Opus 5.5", "Effort Auto", "Mode Manual".
Nothing held that. test:composer now requires each one's visible text to
start with its title and end with its value, at every width and theme, in
Chat and in Dev; with the titles taken out it fails 24 times. Tune.test.tsx
says the same in jsdom.

test:composer also opens the Model picker, beside Effort and Mode: a panel
seen on screen, beside its word on a laptop, and put away by Escape.

Part of hanzo-inc/app#444
Part of hanzo-inc/app#313

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zeekay added a commit to hanzoai/app that referenced this pull request Nov 20, 2026
Effort/Mode picker fix is already merged upstream (hanzoai/ui#327)
and published as @hanzo/ui 8.33.6. Bump the host catalog pin and
patched dependency so hanzo.app/chat picks it up.

Co-authored-by: Zach Kelling <z@hanzo.ai>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants