Repository navigation
fix(chat): Effort and Mode lists open where they can be seen - #327
Merged
Merged
Conversation
Tooltip and Popover share the empty scope, and a Tooltip provides its own Popper and Popover context. With the Tooltip between Popover and PopoverTrigger, the trigger anchored the Tooltip and the Popover content was never placed: it stayed at the top-left at opacity 0. Nest the Popover inside the TooltipTrigger, as the Model picker does. test:composer opens Effort (and Mode on Dev) at every width and requires a list that is seen on screen, beside its word on desktop, and gone after Escape.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Darkhorse7stars
added a commit
that referenced
this pull request
Nov 20, 2026
… Mode titled on the row (#328) Releases #327 (the Effort and Mode lists open where they can be seen, hanzo-inc/app#444) and holds the row's titles in place (hanzo-inc/app#313). The closed words already read as their title over (or beside, on a phone) their value since 8.33.5: "Model Opus 5.5", "Effort Auto", "Mode Manual". Nothing held that. test:composer now requires each one's visible text to start with its title and end with its value, at every width and theme, in Chat and in Dev; with the titles taken out it fails 24 times. Tune.test.tsx says the same in jsdom. test:composer also opens the Model picker, beside Effort and Mode: a panel seen on screen, beside its word on a laptop, and put away by Escape. Part of hanzo-inc/app#444 Part of hanzo-inc/app#313 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 20, 2026
zeekay
added a commit
to hanzoai/app
that referenced
this pull request
Nov 20, 2026
Effort/Mode picker fix is already merged upstream (hanzoai/ui#327) and published as @hanzo/ui 8.33.6. Bump the host catalog pin and patched dependency so hanzo.app/chat picks it up. Co-authored-by: Zach Kelling <z@hanzo.ai> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
On hanzo.app/chat, clicking Effort does nothing. The list opens but is never placed: it sits at the top-left at opacity 0. Mode on Dev has the same bug. Model works. The bug came in with #326.
Cause
Tooltip and Popover share the empty scope, and a Tooltip provides its own Popper and Popover context (
@hanzogui/tooltipTooltip.tsx:232-251). InOpens()the Tooltip sat betweenPopoverandPopoverTrigger, so the trigger anchored the Tooltip, and the Popover content never got an anchor.Fix
Opens()now nests the Popover inside theTooltipTrigger, the same structurePick()uses for the Model picker. It is one shape for all three controls. No other place in ui has the old shape:gallery.tsxandgallery/menus.tsxkeep the two side by side.Test
test:composernow opens Effort (and Mode on Dev) at every width and theme. It requires a list that is seen on screen, beside its word on desktop, and gone after Escape.seen:falseat 7,7, matching live).Checks